From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B5CC433DF for ; Wed, 27 May 2020 19:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E13D42078C for ; Wed, 27 May 2020 19:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590606390; bh=aG2AdqsO+CyEMtyrHhPK09QZxRhGgxhiWdKnLjkZ3co=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=TP3ClwooxzjFJirwRmfcDbvb2FJPGd4vkwa4nlpi80gK3ofk185YbNLoFjHnWBP68 vgfv1XRpfnR0UotcW2IMpYGc1rj+1qio1VpO3/el+hpJJm2i48ZMXAEqEstbQDLlaV zSTIOB4zG309iOLTzh6q4ctmD2wy9E6KQA/7h+68= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726938AbgE0TG0 (ORCPT ); Wed, 27 May 2020 15:06:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:45286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgE0TG0 (ORCPT ); Wed, 27 May 2020 15:06:26 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA26B2078C; Wed, 27 May 2020 19:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590606385; bh=aG2AdqsO+CyEMtyrHhPK09QZxRhGgxhiWdKnLjkZ3co=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=vda/BOl/7s8cKLqRnRSdBNZScYvIpTuDdK/zG0cH/MQl+p6hap9UgqzlB3sU14j7Q PhKwh1t6C0GCWdMr5vmR1gNk1KLId9jU+UAxmuXzbd8bEfE3cQsEhuLCUTCfm/jwXv SHbVfwauPCXrQfxRtE4pf66Nb1gQ1ZzvZxbpJDvU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1590590362-11570-1-git-send-email-yangtiezhu@loongson.cn> References: <1590590362-11570-1-git-send-email-yangtiezhu@loongson.cn> Subject: Re: [PATCH v4 1/2] clk: hisilicon: Use correct return value about hisi_reset_init() From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li , Tiezhu Yang To: Michael Turquette , Tiezhu Yang Date: Wed, 27 May 2020 12:06:24 -0700 Message-ID: <159060638492.88029.3855641102752089121@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Tiezhu Yang (2020-05-27 07:39:21) > The return value about hisi_reset_init() is not correct, fix it. >=20 > Fixes: e9a2310fb689 ("reset: hisilicon: fix potential NULL pointer derefe= rence") hisi_reset_init() returns NULL on error in that commit. This patch doesn't make sense. > Signed-off-by: Tiezhu Yang > --- >