From: Stephen Boyd <sboyd@kernel.org>
To: Fabio Estevam <festevam@gmail.com>, robh@kernel.org
Cc: robh+dt@kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] dt-bindings: clock: dac: syscon-icst: Remove unneeded unit name
Date: Wed, 27 May 2020 17:53:24 -0700 [thread overview]
Message-ID: <159062720498.69627.5411198594058635183@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200328184958.16134-1-festevam@gmail.com>
Quoting Fabio Estevam (2020-03-28 11:49:58)
> The following warnings are seen with 'make dt_binding_check':
>
> Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_vs_reg): /example-0/clock@00: node has a unit name, but no reg or ranges property
> Documentation/devicetree/bindings/clock/arm,syscon-icst.example.dts:17.16-24.11: Warning (unit_address_format): /example-0/clock@00: unit name should not have leading 0s
>
> Fix them by removing the unneeded clock unit name.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
Rob were you going to pick this up? Doesn't look like a critical warning
to fix in v5.7 final right now.
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index de9a465096db..444aeea27db8 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -91,7 +91,7 @@ required:
>
> examples:
> - |
> - vco1: clock@00 {
> + vco1: clock {
> compatible = "arm,impd1-vco1";
> #clock-cells = <0>;
> lock-offset = <0x08>;
next prev parent reply other threads:[~2020-05-28 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 18:49 [PATCH] dt-bindings: clock: dac: syscon-icst: Remove unneeded unit name Fabio Estevam
2020-05-28 0:53 ` Stephen Boyd [this message]
2020-06-03 12:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159062720498.69627.5411198594058635183@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).