linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965
@ 2020-04-04 16:15 Adam Ford
  2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Adam Ford @ 2020-04-04 16:15 UTC (permalink / raw)
  To: linux-clk
  Cc: aford, charles.stevens, Adam Ford, Michael Turquette,
	Stephen Boyd, Rob Herring, Marek Vasut, devicetree, linux-kernel

Update IDT VersaClock 5 driver to support 5P49V6965.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c

index 24fef51fbcb5..fa96659f8023
--- a/drivers/clk/clk-versaclock5.c
+++ b/drivers/clk/clk-versaclock5.c
@@ -124,6 +124,7 @@ enum vc5_model {
 	IDT_VC5_5P49V5933,
 	IDT_VC5_5P49V5935,
 	IDT_VC6_5P49V6901,
+	IDT_VC6_5P49V6965,
 };
 
 /* Structure to describe features of a particular VC5 model */
@@ -683,6 +684,7 @@ static int vc5_map_index_to_output(const enum vc5_model model,
 	case IDT_VC5_5P49V5925:
 	case IDT_VC5_5P49V5935:
 	case IDT_VC6_5P49V6901:
+	case IDT_VC6_5P49V6965:
 	default:
 		return n;
 	}
@@ -956,12 +958,20 @@ static const struct vc5_chip_info idt_5p49v6901_info = {
 	.flags = VC5_HAS_PFD_FREQ_DBL,
 };
 
+static const struct vc5_chip_info idt_5p49v6965_info = {
+	.model = IDT_VC6_5P49V6965,
+	.clk_fod_cnt = 4,
+	.clk_out_cnt = 5,
+	.flags = 0,
+};
+
 static const struct i2c_device_id vc5_id[] = {
 	{ "5p49v5923", .driver_data = IDT_VC5_5P49V5923 },
 	{ "5p49v5925", .driver_data = IDT_VC5_5P49V5925 },
 	{ "5p49v5933", .driver_data = IDT_VC5_5P49V5933 },
 	{ "5p49v5935", .driver_data = IDT_VC5_5P49V5935 },
 	{ "5p49v6901", .driver_data = IDT_VC6_5P49V6901 },
+	{ "5p49v6965", .driver_data = IDT_VC6_5P49V6965 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, vc5_id);
@@ -972,6 +982,7 @@ static const struct of_device_id clk_vc5_of_match[] = {
 	{ .compatible = "idt,5p49v5933", .data = &idt_5p49v5933_info },
 	{ .compatible = "idt,5p49v5935", .data = &idt_5p49v5935_info },
 	{ .compatible = "idt,5p49v6901", .data = &idt_5p49v6901_info },
+	{ .compatible = "idt,5p49v6965", .data = &idt_5p49v6965_info },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, clk_vc5_of_match);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2020-04-04 16:15 [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
@ 2020-04-04 16:15 ` Adam Ford
  2020-04-14 18:15   ` Rob Herring
  2020-05-29  4:05   ` Stephen Boyd
  2020-05-02 10:53 ` [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
  2020-05-29  4:04 ` Stephen Boyd
  2 siblings, 2 replies; 10+ messages in thread
From: Adam Ford @ 2020-04-04 16:15 UTC (permalink / raw)
  To: linux-clk
  Cc: aford, charles.stevens, Adam Ford, Michael Turquette,
	Stephen Boyd, Rob Herring, Marek Vasut, devicetree, linux-kernel

IDT VersaClock 5 5P49V6965 has 5 clock outputs, 4 fractional dividers.

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
index 05a245c9df08..bcff681a4bd0 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
@@ -12,6 +12,7 @@ Required properties:
 		"idt,5p49v5933"
 		"idt,5p49v5935"
 		"idt,5p49v6901"
+		"idt,5p49v6965"
 - reg:		i2c device address, shall be 0x68 or 0x6a.
 - #clock-cells:	from common clock binding; shall be set to 1.
 - clocks:	from common clock binding; list of parent clock handles,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
@ 2020-04-14 18:15   ` Rob Herring
  2020-05-29  4:05   ` Stephen Boyd
  1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-04-14 18:15 UTC (permalink / raw)
  To: Adam Ford
  Cc: linux-clk, aford, charles.stevens, Adam Ford, Michael Turquette,
	Stephen Boyd, Marek Vasut, devicetree, linux-kernel

On Sat,  4 Apr 2020 11:15:36 -0500, Adam Ford wrote:
> IDT VersaClock 5 5P49V6965 has 5 clock outputs, 4 fractional dividers.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965
  2020-04-04 16:15 [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
  2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
@ 2020-05-02 10:53 ` Adam Ford
  2020-05-29  4:04 ` Stephen Boyd
  2 siblings, 0 replies; 10+ messages in thread
From: Adam Ford @ 2020-05-02 10:53 UTC (permalink / raw)
  To: linux-clk
  Cc: Adam Ford-BE, Charles Stevens, Michael Turquette, Stephen Boyd,
	Rob Herring, Marek Vasut, devicetree, Linux Kernel Mailing List

On Sat, Apr 4, 2020 at 11:15 AM Adam Ford <aford173@gmail.com> wrote:
>
> Update IDT VersaClock 5 driver to support 5P49V6965.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>

Gentle ping.   Rob H has given the 2nd which adds the bindings his
'signed-of-by'

Once this has been approved, I'll be issuing an update to an another
patch series for this same clock, and once those have been approved,
I'll be introducing a new board, but I need this patch approved before
I can do that.

thanks,

adam

> diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
>
> index 24fef51fbcb5..fa96659f8023
> --- a/drivers/clk/clk-versaclock5.c
> +++ b/drivers/clk/clk-versaclock5.c
> @@ -124,6 +124,7 @@ enum vc5_model {
>         IDT_VC5_5P49V5933,
>         IDT_VC5_5P49V5935,
>         IDT_VC6_5P49V6901,
> +       IDT_VC6_5P49V6965,
>  };
>
>  /* Structure to describe features of a particular VC5 model */
> @@ -683,6 +684,7 @@ static int vc5_map_index_to_output(const enum vc5_model model,
>         case IDT_VC5_5P49V5925:
>         case IDT_VC5_5P49V5935:
>         case IDT_VC6_5P49V6901:
> +       case IDT_VC6_5P49V6965:
>         default:
>                 return n;
>         }
> @@ -956,12 +958,20 @@ static const struct vc5_chip_info idt_5p49v6901_info = {
>         .flags = VC5_HAS_PFD_FREQ_DBL,
>  };
>
> +static const struct vc5_chip_info idt_5p49v6965_info = {
> +       .model = IDT_VC6_5P49V6965,
> +       .clk_fod_cnt = 4,
> +       .clk_out_cnt = 5,
> +       .flags = 0,
> +};
> +
>  static const struct i2c_device_id vc5_id[] = {
>         { "5p49v5923", .driver_data = IDT_VC5_5P49V5923 },
>         { "5p49v5925", .driver_data = IDT_VC5_5P49V5925 },
>         { "5p49v5933", .driver_data = IDT_VC5_5P49V5933 },
>         { "5p49v5935", .driver_data = IDT_VC5_5P49V5935 },
>         { "5p49v6901", .driver_data = IDT_VC6_5P49V6901 },
> +       { "5p49v6965", .driver_data = IDT_VC6_5P49V6965 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, vc5_id);
> @@ -972,6 +982,7 @@ static const struct of_device_id clk_vc5_of_match[] = {
>         { .compatible = "idt,5p49v5933", .data = &idt_5p49v5933_info },
>         { .compatible = "idt,5p49v5935", .data = &idt_5p49v5935_info },
>         { .compatible = "idt,5p49v6901", .data = &idt_5p49v6901_info },
> +       { .compatible = "idt,5p49v6965", .data = &idt_5p49v6965_info },
>         { },
>  };
>  MODULE_DEVICE_TABLE(of, clk_vc5_of_match);
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965
  2020-04-04 16:15 [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
  2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
  2020-05-02 10:53 ` [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
@ 2020-05-29  4:04 ` Stephen Boyd
  2 siblings, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2020-05-29  4:04 UTC (permalink / raw)
  To: Adam Ford, linux-clk
  Cc: aford, charles.stevens, Adam Ford, Michael Turquette,
	Rob Herring, Marek Vasut, devicetree, linux-kernel

Quoting Adam Ford (2020-04-04 09:15:35)
> Update IDT VersaClock 5 driver to support 5P49V6965.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c
> 
> index 24fef51fbcb5..fa96659f8023
> --- a/drivers/clk/clk-versaclock5.c

Applied to clk-next

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
  2020-04-14 18:15   ` Rob Herring
@ 2020-05-29  4:05   ` Stephen Boyd
  1 sibling, 0 replies; 10+ messages in thread
From: Stephen Boyd @ 2020-05-29  4:05 UTC (permalink / raw)
  To: Adam Ford, linux-clk
  Cc: aford, charles.stevens, Adam Ford, Michael Turquette,
	Rob Herring, Marek Vasut, devicetree, linux-kernel

Quoting Adam Ford (2020-04-04 09:15:36)
> IDT VersaClock 5 5P49V6965 has 5 clock outputs, 4 fractional dividers.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> index 05a245c9df08..bcff681a4bd0 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt

Applied to clk-next

BTW, the patch format threw my scripts off because there isn't a triple
dash after the SoB line.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2017-07-09 17:38     ` Vladimir Barinov
@ 2017-07-09 17:42       ` Marek Vasut
  0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2017-07-09 17:42 UTC (permalink / raw)
  To: Vladimir Barinov, Michael Turquette, Stephen Boyd, Rob Herring,
	Mark Rutland
  Cc: linux-clk, linux-kernel, devicetree

On 07/09/2017 07:38 PM, Vladimir Barinov wrote:
> On 09.07.2017 16:31, Marek Vasut wrote:
>> On 07/07/2017 03:57 AM, Vladimir Barinov wrote:
>>> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>>>
>>> IDT VersaClock 5 5P49V5925 has 4 clock outputs
>> In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs,
>> 4 from FODs and 1 I2C_OUTB).
> That was a copy typo. Thank you for pointing to this.
> 
>>
>>> , 4 fractional dividers.
>>> Input clock source can be taken only from external reference clock.
>>>
>>> Signed-off-by: Vladimir Barinov
>>> <vladimir.barinov+renesas@cogentembedded.com>
>> You might want to rebase this on top of and retest against [1], there
>> are 8 patches in total fixing some stuff and adding VC6 support.
>>
>> [1] https://patchwork.kernel.org/patch/9831797/
> 
> I've  tested your patch series with ULCB board and HDMI display.
> I will rebase 5P49V5925 patches on top of them.

Thanks! That makes things easy :)

-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2017-07-09 13:31   ` Marek Vasut
@ 2017-07-09 17:38     ` Vladimir Barinov
  2017-07-09 17:42       ` Marek Vasut
  0 siblings, 1 reply; 10+ messages in thread
From: Vladimir Barinov @ 2017-07-09 17:38 UTC (permalink / raw)
  To: Marek Vasut, Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland
  Cc: linux-clk, linux-kernel, devicetree

On 09.07.2017 16:31, Marek Vasut wrote:
> On 07/07/2017 03:57 AM, Vladimir Barinov wrote:
>> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>>
>> IDT VersaClock 5 5P49V5925 has 4 clock outputs
> In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs,
> 4 from FODs and 1 I2C_OUTB).
That was a copy typo. Thank you for pointing to this.

>
>> , 4 fractional dividers.
>> Input clock source can be taken only from external reference clock.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> You might want to rebase this on top of and retest against [1], there
> are 8 patches in total fixing some stuff and adding VC6 support.
>
> [1] https://patchwork.kernel.org/patch/9831797/

I've  tested your patch series with ULCB board and HDMI display.
I will rebase 5P49V5925 patches on top of them.

Regards,
Vladimir

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2017-07-07  1:57 ` [PATCH 2/2] dt: Add bindings for " Vladimir Barinov
@ 2017-07-09 13:31   ` Marek Vasut
  2017-07-09 17:38     ` Vladimir Barinov
  0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2017-07-09 13:31 UTC (permalink / raw)
  To: Vladimir Barinov, Michael Turquette, Stephen Boyd, Rob Herring,
	Mark Rutland
  Cc: linux-clk, linux-kernel, devicetree

On 07/07/2017 03:57 AM, Vladimir Barinov wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> 
> IDT VersaClock 5 5P49V5925 has 4 clock outputs

In 1/2 you said it has 4 FODs and 5 outputs (and it does have 5 outputs,
4 from FODs and 1 I2C_OUTB).

>, 4 fractional dividers.
> Input clock source can be taken only from external reference clock.
> 
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

You might want to rebase this on top of and retest against [1], there
are 8 patches in total fixing some stuff and adding VC6 support.

[1] https://patchwork.kernel.org/patch/9831797/

> ---
>  Documentation/devicetree/bindings/clock/idt,versaclock5.txt | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> index 53d7e50..a1ad9e0 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> @@ -6,19 +6,21 @@ from 3 to 12 output clocks.
>  ==I2C device node==
>  
>  Required properties:
> -- compatible:	shall be one of "idt,5p49v5923" , "idt,5p49v5933" ,
> -		"idt,5p49v5935".
> +- compatible:	shall be one of "idt,5p49v5923" , "idt,5p49v5925" ,
> +		"idt,5p49v5933", "idt,5p49v5935".
>  - reg:		i2c device address, shall be 0x68 or 0x6a.
>  - #clock-cells:	from common clock binding; shall be set to 1.
>  - clocks:	from common clock binding; list of parent clock handles,
> -		- 5p49v5923: (required) either or both of XTAL or CLKIN
> +		- 5p49v5923 and
> +		- 5p49v5925: (required) either or both of XTAL or CLKIN
>  					reference clock.
>  		- 5p49v5933 and
>  		- 5p49v5935: (optional) property not present (internal
>  					Xtal used) or CLKIN reference
>  					clock.
>  - clock-names:	from common clock binding; clock input names, can be
> -		- 5p49v5923: (required) either or both of "xin", "clkin".
> +		- 5p49v5923 and
> +		- 5p49v5925: (required) either or both of "xin", "clkin".
>  		- 5p49v5933 and
>  		- 5p49v5935: (optional) property not present or "clkin".
>  
> @@ -37,6 +39,7 @@ clock specifier, the following mapping applies:
>  	1 -- OUT1
>  	2 -- OUT4
>  
> +5P49V5925 and
>  5P49V5935:
>  	0 -- OUT0_SEL_I2CB
>  	1 -- OUT1
> 


-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925
  2017-07-07  1:57 [PATCH 0/2] clk: vc5: Add IDT VersaClock 5P49V5925 Vladimir Barinov
@ 2017-07-07  1:57 ` Vladimir Barinov
  2017-07-09 13:31   ` Marek Vasut
  0 siblings, 1 reply; 10+ messages in thread
From: Vladimir Barinov @ 2017-07-07  1:57 UTC (permalink / raw)
  To: Marek Vasut, Michael Turquette, Stephen Boyd, Rob Herring, Mark Rutland
  Cc: linux-clk, linux-kernel, devicetree, Vladimir Barinov

From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

IDT VersaClock 5 5P49V5925 has 4 clock outputs, 4 fractional dividers.
Input clock source can be taken only from external reference clock.

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
---
 Documentation/devicetree/bindings/clock/idt,versaclock5.txt | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
index 53d7e50..a1ad9e0 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
@@ -6,19 +6,21 @@ from 3 to 12 output clocks.
 ==I2C device node==
 
 Required properties:
-- compatible:	shall be one of "idt,5p49v5923" , "idt,5p49v5933" ,
-		"idt,5p49v5935".
+- compatible:	shall be one of "idt,5p49v5923" , "idt,5p49v5925" ,
+		"idt,5p49v5933", "idt,5p49v5935".
 - reg:		i2c device address, shall be 0x68 or 0x6a.
 - #clock-cells:	from common clock binding; shall be set to 1.
 - clocks:	from common clock binding; list of parent clock handles,
-		- 5p49v5923: (required) either or both of XTAL or CLKIN
+		- 5p49v5923 and
+		- 5p49v5925: (required) either or both of XTAL or CLKIN
 					reference clock.
 		- 5p49v5933 and
 		- 5p49v5935: (optional) property not present (internal
 					Xtal used) or CLKIN reference
 					clock.
 - clock-names:	from common clock binding; clock input names, can be
-		- 5p49v5923: (required) either or both of "xin", "clkin".
+		- 5p49v5923 and
+		- 5p49v5925: (required) either or both of "xin", "clkin".
 		- 5p49v5933 and
 		- 5p49v5935: (optional) property not present or "clkin".
 
@@ -37,6 +39,7 @@ clock specifier, the following mapping applies:
 	1 -- OUT1
 	2 -- OUT4
 
+5P49V5925 and
 5P49V5935:
 	0 -- OUT0_SEL_I2CB
 	1 -- OUT1
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-05-29  4:05 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 16:15 [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
2020-04-04 16:15 ` [PATCH 2/2] dt: Add bindings for IDT VersaClock 5P49V5925 Adam Ford
2020-04-14 18:15   ` Rob Herring
2020-05-29  4:05   ` Stephen Boyd
2020-05-02 10:53 ` [PATCH 1/2] clk: vc5: Add support for IDT VersaClock 5P49V6965 Adam Ford
2020-05-29  4:04 ` Stephen Boyd
  -- strict thread matches above, loose matches on Subject: below --
2017-07-07  1:57 [PATCH 0/2] clk: vc5: Add IDT VersaClock 5P49V5925 Vladimir Barinov
2017-07-07  1:57 ` [PATCH 2/2] dt: Add bindings for " Vladimir Barinov
2017-07-09 13:31   ` Marek Vasut
2017-07-09 17:38     ` Vladimir Barinov
2017-07-09 17:42       ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).