From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC316C433E0 for ; Thu, 23 Jul 2020 22:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEC9E20792 for ; Thu, 23 Jul 2020 22:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595544350; bh=ysaoh10oMPlqijllUrvR5st6IAHAnCP1ok7GBN063iM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=t0wM20y4ZhYHxiJkPQhMgt5k/sE3VaNL6ltAW0S0DFE+hwEk1eyKRa2zqgJsEna7X Ay3Df5zGVNsRfVa1bmUXT7WWNfjX4g02tJlJiLtWFDfD/eg9PMMIFOXtARf/r4fI07 DneWpPjBqM5YP7Ent1QdmuxCaNeZ5h56U4YoePAg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgGWWpu (ORCPT ); Thu, 23 Jul 2020 18:45:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:50970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgGWWpu (ORCPT ); Thu, 23 Jul 2020 18:45:50 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A25CB206E3; Thu, 23 Jul 2020 22:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595544349; bh=ysaoh10oMPlqijllUrvR5st6IAHAnCP1ok7GBN063iM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=WCcYMlYtQhuqzwqtbEjUfMNa/JR+hxs2nJB8An5VFT0X8E7T8ciY8dhMir1xkTuMd t6+t/5h7NxsPXkAsghPFDJd+rMupZVID8fo//8niGbw/Xpo1pb2SzXl1HX7TPs+2dB 3fA8r1sv+vJ4djtqkSOKLmED2gZiv6gx/WKwg7+c= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200626115433.125735-1-maxime@cerno.tech> References: <20200626115433.125735-1-maxime@cerno.tech> Subject: Re: [PATCH] dt-bindings: arm: bcm: Add a select to the RPI Firmware binding From: Stephen Boyd Cc: linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org, Mark Rutland , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Florian Fainelli , Maxime Ripard To: Maxime Ripard , Mike Turquette , Nicolas Saenz Julienne Date: Thu, 23 Jul 2020 15:45:48 -0700 Message-ID: <159554434893.3847286.8491922177659230646@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Maxime Ripard (2020-06-26 04:54:33) > The RaspberryPi firmware binding uses two compatible, include simple-bus. > The select statement generated by default will thus select any node that > has simple-bus, not all of them being the raspberrypi firmware node. >=20 > This results in warnings being wrongfully reported. Let's add a custom > select statement to fix that. >=20 > Fixes: 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware bin= ding to YAML") > Signed-off-by: Maxime Ripard >=20 > --- >=20 > The original binding has been merged through the clock tree, so it should > be merged there. >=20 > Even though the original binding (and the DT) are using the simple-bus > compatible, this creates some DTC warnings since the firmware really isn't > a bus, so the node name doesn't match what a bus should have, none of the > children have a reg property, #address-cells and #size-cells are missing, > etc. >=20 > I can only guess that simple-bus was used to make the sub-devices probe, > but maybe simple-mfd would be more appropriate here? > --- > .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) Hmm. I'm still seeing warnings. Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.exam= ple.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: = missing or emp ty reg/ranges property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.exam= ple.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|ax= i|ahb|apb)(@[0-9a-f]+)?$' Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.exam= ple.dt.yaml: firmware: '#address-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.exam= ple.dt.yaml: firmware: '#size-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.exam= ple.dt.yaml: firmware: 'ranges' is a required property