* [PATCH] clk: drop unused function __clk_get_flags
@ 2020-08-01 8:53 Julia Lawall
2020-08-03 20:53 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2020-08-01 8:53 UTC (permalink / raw)
To: Michael Turquette; +Cc: kernel-janitors, Stephen Boyd, linux-clk, linux-kernel
The function __clk_get_flags has not been used since the April 2019
commit a348f05361c9 ("ARM: omap2+: hwmod: drop CLK_IS_BASIC
flag usage"). Other uses were removed in June 2015, eg by
commit 98d8a60eccee ("clk: Convert __clk_get_flags() to
clk_hw_get_flags()"), which shows how clk_hw_get_flags can easily
be used instead.
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/clk/clk.c | 6 ------
include/linux/clk-provider.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 8aed0c3ff122..0a9261a099bd 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -500,12 +500,6 @@ static unsigned long clk_core_get_accuracy_no_lock(struct clk_core *core)
return core->accuracy;
}
-unsigned long __clk_get_flags(struct clk *clk)
-{
- return !clk ? 0 : clk->core->flags;
-}
-EXPORT_SYMBOL_GPL(__clk_get_flags);
-
unsigned long clk_hw_get_flags(const struct clk_hw *hw)
{
return hw->core->flags;
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 6f815be99b77..03a5de5f99f4 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -1096,7 +1096,6 @@ int clk_hw_get_parent_index(struct clk_hw *hw);
int clk_hw_set_parent(struct clk_hw *hw, struct clk_hw *new_parent);
unsigned int __clk_get_enable_count(struct clk *clk);
unsigned long clk_hw_get_rate(const struct clk_hw *hw);
-unsigned long __clk_get_flags(struct clk *clk);
unsigned long clk_hw_get_flags(const struct clk_hw *hw);
#define clk_hw_can_set_rate_parent(hw) \
(clk_hw_get_flags((hw)) & CLK_SET_RATE_PARENT)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: drop unused function __clk_get_flags
2020-08-01 8:53 [PATCH] clk: drop unused function __clk_get_flags Julia Lawall
@ 2020-08-03 20:53 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2020-08-03 20:53 UTC (permalink / raw)
To: Julia Lawall, Michael Turquette; +Cc: kernel-janitors, linux-clk, linux-kernel
Quoting Julia Lawall (2020-08-01 01:53:42)
> The function __clk_get_flags has not been used since the April 2019
> commit a348f05361c9 ("ARM: omap2+: hwmod: drop CLK_IS_BASIC
> flag usage"). Other uses were removed in June 2015, eg by
> commit 98d8a60eccee ("clk: Convert __clk_get_flags() to
> clk_hw_get_flags()"), which shows how clk_hw_get_flags can easily
> be used instead.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-03 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-01 8:53 [PATCH] clk: drop unused function __clk_get_flags Julia Lawall
2020-08-03 20:53 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).