From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B840C433FE for ; Sat, 5 Dec 2020 05:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F76322D3E for ; Sat, 5 Dec 2020 05:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728301AbgLEFr3 (ORCPT ); Sat, 5 Dec 2020 00:47:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:59130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgLEFr2 (ORCPT ); Sat, 5 Dec 2020 00:47:28 -0500 Content-Type: text/plain; charset="utf-8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607147207; bh=N9944AoUzOF/flZHzHrrl01FA35Tkc7qrcy9VwvBa84=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=EjQZW4pQHa+WwewOqtB4/JLvvH2kll+61Eynml0eR3moC2QcR9IgwB0ChVGSv2UZI cyHMcn5X8P76u87HjP+r9oMYJUTVQhcznOa6vKzqO5nJN4X9RLD2tgQmLCDe48sjeU 0TLWt2HyBWar1nLu5yNoyjb3snc26/T3/mosIEFc7zyULFzTMu12+uXInYPNLLQho3 cE8K5UucVEc52demwnAmZKOodffzEzajr3iLZOBYt23smAv6DY9kEtMQ6wEtRYVCDq xrUQtsYPpnIWBiA3NzVbt8Ins9KgT2cuSg5lgByo55h8ia8FQqKwtnBwlL+zWnw9hx WVL7f3SrDCodA== MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201202032500.206346-8-damien.lemoal@wdc.com> References: <20201202032500.206346-1-damien.lemoal@wdc.com> <20201202032500.206346-8-damien.lemoal@wdc.com> Subject: Re: [PATCH v4 07/21] dt-binding: clock: Document canaan,k210-clk bindings From: Stephen Boyd Cc: Sean Anderson To: Damien Le Moal , Linus Walleij , Palmer Dabbelt , Philipp Zabel , Rob Herring , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org Date: Fri, 04 Dec 2020 21:46:46 -0800 Message-ID: <160714720649.1580929.10979600141579296560@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Damien Le Moal (2020-12-01 19:24:46) > diff --git a/Documentation/devicetree/bindings/clock/canaan,k210-clk.yaml= b/Documentation/devicetree/bindings/clock/canaan,k210-clk.yaml > new file mode 100644 > index 000000000000..3547916a2421 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/canaan,k210-clk.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/canaan,k210-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Canaan Kendryte K210 Clock Device Tree Bindings > + > +maintainers: > + - Damien Le Moal > + > +description: | > + Canaan Kendryte K210 SoC clocks driver bindings. The clock > + controller node must be defined as a child node of the K210 > + system controller node. > + > + See also: > + - dt-bindings/clock/k210-clk.h > + > +properties: > + compatible: > + const: canaan,k210-clk > + > + clocks: > + maxItems: 1 > + description: > + System fixed rate oscillator clock. Is it optional? I suspect not and it can always be specified, so drop maxItems. > + > + '#clock-cells': > + const: 1 > + > +required: > + - compatible > + - '#clock-cells' > + - clocks Maybe also add clock-names as an optional property, but doesn't really matter if there's only one clk.