From: Stephen Boyd <sboyd@kernel.org>
To: Lee Jones <lee.jones@linaro.org>, Wendell Lin <wendell.lin@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
ARM/Mediatek SoC support <linux-mediatek@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
open list: OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>,
wsd_upstream <wsd_upstream@mediatek.com>, ;
Subject: Re: [PATCH 1/1] clk: Export clk_register_composite
Date: Fri, 04 Jun 2021 12:19:31 -0700 [thread overview]
Message-ID: <162283437157.1835121.5925083479747882207@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210604132335.GK2435141@dell>
Quoting Lee Jones (2021-06-04 06:23:35)
> On Fri, 04 Jun 2021, Wendell Lin wrote:
>
> > On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote:
> > > On Fri, 04 Jun 2021, Lee Jones wrote:
> > >
> > > > On Thu, 03 Jun 2021, Stephen Boyd wrote:
> > > >
> > > > > Quoting Lee Jones (2021-05-20 09:07:42)
> > > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin <wendell.lin@mediatek.com> wrote:
> > > > > >
> > > > > > Hi Matthias and all,
> > > > > >
> > > > > > Gentle ping on this patch.
> > > > > >
> > > > > >
> > > > > > What about a not-so-gentle ping on this patch? Grrrr... :)
> > > > > >
> > > > > > FYI, this is still required by more than one source.
> > > > > >
> > > > > > Please help get this out of all of the vendor trees please.
> > > > > >
> > > > >
> > > > > Is there an in-kernel user?
> > > >
> > > > How can there be? It's not exported yet. :)
> > > >
> > > > However there shouldn't be any barriers for vendors represented in
> > > > Mainline to build their drivers as modules if they so wish. If/when
> > > > they do, this will need to be exported.
> > >
> > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek
> > > driver?
> > >
> > This is because Mediatek clock driver would be built as kernel module,
> > so clk_register_composite() used should be exported, then we could use
> > it.
> >
> > Please refer:
> > [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support
> > https://lkml.org/lkml/2020/7/1/124
> > +EXPORT_SYMBOL(mtk_clk_register_composites);
> >
> > clk_register_composite() is used by Mediatek clk kernel module.
> > From export symbol: mtk_clk_register_composites.
>
> Perfect. Thanks for the clarification.
>
> Anything else you need from us Stephen?
>
Is the mediatek driver compilable as a module? Last time I checked it
wasn't a module. I want an upstream modular driver that uses the symbol.
Otherwise we're exporting symbols when it doesn't need to be.
prev parent reply other threads:[~2021-06-04 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 8:32 [PATCH 1/1] clk: Export clk_register_composite Wendell Lin
2020-08-10 9:36 ` Wendell Lin
[not found] ` <CAF2Aj3hZB08d8x6XOqsP4m5fv76fWH48U95j8ugLt-YWFJ-kkA@mail.gmail.com>
[not found] ` <162276982204.1835121.10976600065855289763@swboyd.mtv.corp.google.com>
[not found] ` <20210604082427.GE2435141@dell>
[not found] ` <20210604082524.GF2435141@dell>
2021-06-04 10:22 ` Wendell Lin
2021-06-04 13:23 ` Lee Jones
2021-06-04 19:19 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162283437157.1835121.5925083479747882207@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=wendell.lin@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).