From: Stephen Boyd <sboyd@kernel.org>
To: Robert Marko <robimarko@gmail.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
sivaprak@codeaurora.org, speriaka@codeaurora.org
Cc: Robert Marko <robimarko@gmail.com>
Subject: Re: [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops
Date: Sun, 27 Jun 2021 17:07:29 -0700 [thread overview]
Message-ID: <162483884998.3259633.3733659727822681631@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210518175153.3176764-1-robimarko@gmail.com>
Quoting Robert Marko (2021-05-18 10:51:53)
> Fix PCI-E clock related kernel oops that are causes by missing
> parent_names.
>
> Without the use of parent_names kernel will panic on
> clk_core_get_parent_by_index() due to a NULL pointer.
>
> Without this earlycon is needed to even catch the OOPS as it will reset
> the board before serial is initialized.
Can you share the oops message here in the commit text?
>
> Fixes: f0cfcf1ade20 ("clk: qcom: ipq8074: Add missing clocks for pcie")
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> drivers/clk/qcom/gcc-ipq8074.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> index 0c619ed35c82..8d8b1717a203 100644
> --- a/drivers/clk/qcom/gcc-ipq8074.c
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> @@ -4357,8 +4357,7 @@ static struct clk_rcg2 pcie0_rchng_clk_src = {
> .parent_map = gcc_xo_gpll0_map,
> .clkr.hw.init = &(struct clk_init_data){
> .name = "pcie0_rchng_clk_src",
> - .parent_hws = (const struct clk_hw *[]) {
> - &gpll0.clkr.hw },
> + .parent_names = gcc_xo_gpll0,
This seems to imply that we need to have two parents but we didn't
realize that was the case. Ouch! Please use a struct clk_parent_data
array and then use the firmware name for XO and the clk_hw pointer for
gpll0.
> .num_parents = 2,
> .ops = &clk_rcg2_ops,
> },
> @@ -4372,8 +4371,8 @@ static struct clk_branch gcc_pcie0_rchng_clk = {
> .enable_mask = BIT(1),
> .hw.init = &(struct clk_init_data){
> .name = "gcc_pcie0_rchng_clk",
> - .parent_hws = (const struct clk_hw *[]){
> - &pcie0_rchng_clk_src.clkr.hw,
> + .parent_names = (const char *[]){
> + "pcie0_rchng_clk_src",
> },
> .num_parents = 1,
> .flags = CLK_SET_RATE_PARENT,
> @@ -4390,8 +4389,8 @@ static struct clk_branch gcc_pcie0_axi_s_bridge_clk = {
> .enable_mask = BIT(0),
> .hw.init = &(struct clk_init_data){
> .name = "gcc_pcie0_axi_s_bridge_clk",
> - .parent_hws = (const struct clk_hw *[]){
> - &pcie0_axi_clk_src.clkr.hw,
> + .parent_names = (const char *[]){
> + "pcie0_axi_clk_src"
These two hunks can be dropped.
next prev parent reply other threads:[~2021-06-28 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 17:51 [PATCH] clk: qcom: ipq8074: fix PCI-E clock oops Robert Marko
2021-06-28 0:07 ` Stephen Boyd [this message]
2021-09-08 14:28 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162483884998.3259633.3733659727822681631@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robimarko@gmail.com \
--cc=sivaprak@codeaurora.org \
--cc=speriaka@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).