From: Andi Shyti <andi@etezian.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Andi Shyti <andi.shyti@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks
Date: Mon, 4 Jul 2016 19:26:14 +0900 [thread overview]
Message-ID: <20160704102614.GD1257@jack.zhora.eu> (raw)
In-Reply-To: <577A2EFF.2010306@samsung.com>
Hi Sylwester,
> > GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC,
> > - 4, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0),
> > + 4, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0),
>
> As Tomasz pointed out, this should be addressed in the driver/dts,
> we shouldn't be patching board configurations into a per-SoC driver.
> Other boards may want to keep this clock disabled.
The single clock lines are not configured in the exynos5433 dts,
but in the drivers/clk/samsung/clk-exynos5433.c file and it's the
only place where we can set the flags.
> What is an exact problem here, are you perhaps testing suspend to RAM?
> I tested my sound support patches on top of v4.7-rc1 and everything
> seemed to work well, I didn't notice any issues with the audio codec
> which was the only slave on the SPI 1 bus.
Yes, because the audio codec is on SPI1 and its bus line
(spi_busclk0) is CLK_SCLK_SPI1_PERIC while the CLK_SCLK_SPI1 is
set as CLK_IGNORE_UNUSED.
> Doesn't it help when you specify CLK_SCLK_SPI1 as the second clock
> ("spi_busclk0") of the spi_1 bus controller instead of
> CLK_SCLK_SPI0_PERIC? CLK_SCLK_SPI0_PERIC seem to be parent of
> CLK_SCLK_SPI1 so the enable state would be propagated.
nope! :(
For some reasons, if you set in the DTS as spi_busclk0 the
CLK_SCLK_SPI1 from cmu_peric you get a synchronus abort in the
s3c64xx_spi_config (the first read performed on the device).
Andi
next prev parent reply other threads:[~2016-07-04 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 7:15 [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Andi Shyti
2016-06-30 7:15 ` [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks Andi Shyti
2016-07-04 9:40 ` Sylwester Nawrocki
2016-07-04 10:26 ` Andi Shyti [this message]
2016-07-04 15:15 ` Sylwester Nawrocki
2016-07-06 4:51 ` Andi Shyti
2016-07-06 10:40 ` Sylwester Nawrocki
2016-06-30 7:15 ` [PATCH v3 2/2] clk: exynos5433: enable sclk_ioclk for SPI3 Andi Shyti
2016-07-04 3:59 ` [PATCH v3 0/2] mark spi clocks as critical and enable spi3 clocks Tomasz Figa
2016-07-04 4:20 ` Andi Shyti
2016-07-04 4:55 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704102614.GD1257@jack.zhora.eu \
--to=andi@etezian.org \
--cc=andi.shyti@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).