From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Tero Kristo <t-kristo@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>, <linux-omap@vger.kernel.org>,
<linux-clk@vger.kernel.org>
Subject: [PATCH 10/10] clk: ti: make clk-dra7-atl explicitly non-modular
Date: Mon, 4 Jul 2016 17:12:20 -0400 [thread overview]
Message-ID: <20160704211220.5685-11-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160704211220.5685-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
arch/arm/mach-omap2/Kconfig:config SOC_DRA7XX
arch/arm/mach-omap2/Kconfig: bool "TI DRA7XX"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tags etc. since all that information
is already contained at the top of the file in the comments.
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-omap@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/clk/ti/clk-dra7-atl.c | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index c77333230bdf..45d05339d583 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -15,7 +15,7 @@
* GNU General Public License for more details.
*/
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/clk.h>
#include <linux/clk-provider.h>
#include <linux/slab.h>
@@ -295,31 +295,17 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
return ret;
}
-static int of_dra7_atl_clk_remove(struct platform_device *pdev)
-{
- pm_runtime_disable(&pdev->dev);
-
- return 0;
-}
-
static const struct of_device_id of_dra7_atl_clk_match_tbl[] = {
{ .compatible = "ti,dra7-atl", },
{},
};
-MODULE_DEVICE_TABLE(of, of_dra7_atl_clk_match_tbl);
static struct platform_driver dra7_atl_clk_driver = {
.driver = {
.name = "dra7-atl",
+ .suppress_bind_attrs = true,
.of_match_table = of_dra7_atl_clk_match_tbl,
},
.probe = of_dra7_atl_clk_probe,
- .remove = of_dra7_atl_clk_remove,
};
-
-module_platform_driver(dra7_atl_clk_driver);
-
-MODULE_DESCRIPTION("Clock driver for DRA7 Audio Tracking Logic");
-MODULE_ALIAS("platform:dra7-atl-clock");
-MODULE_AUTHOR("Peter Ujfalusi <peter.ujfalusi@ti.com>");
-MODULE_LICENSE("GPL v2");
+builtin_platform_driver(dra7_atl_clk_driver);
--
2.8.4
next prev parent reply other threads:[~2016-07-04 21:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 21:12 [PATCH 00/10] clk: fix/remove module usage in non-modular code Paul Gortmaker
2016-07-04 21:12 ` [PATCH 01/10] clk: meson8b: make it explicitly non-modular Paul Gortmaker
2016-07-06 22:21 ` Michael Turquette
2016-07-04 21:12 ` [PATCH 02/10] clk: meson: make gxbb " Paul Gortmaker
2016-07-06 22:21 ` Michael Turquette
2016-07-04 21:12 ` [PATCH 03/10] clk: mvebu: make cp110-system-controller " Paul Gortmaker
2016-11-04 20:32 ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 04/10] clk: mvebu: make ap806-system-controller " Paul Gortmaker
2016-11-04 20:33 ` Stephen Boyd
2016-07-04 21:12 ` [PATCH 05/10] clk: oxnas: make it " Paul Gortmaker
2016-07-06 13:11 ` Neil Armstrong
2016-07-06 22:21 ` Michael Turquette
2016-07-04 21:12 ` [PATCH 06/10] clk: samsung make clk-exynos-audss " Paul Gortmaker
2016-07-05 9:04 ` Krzysztof Kozlowski
2016-07-05 13:32 ` Paul Gortmaker
2016-07-05 11:02 ` Geert Uytterhoeven
2016-07-05 13:17 ` Paul Gortmaker
2016-07-07 13:12 ` Sylwester Nawrocki
2016-07-04 21:12 ` [PATCH 07/10] clk: samsung: make clk-s5pv210-audss " Paul Gortmaker
2016-07-06 10:49 ` Sylwester Nawrocki
2016-07-13 10:32 ` Sylwester Nawrocki
2016-07-13 21:59 ` Michael Turquette
2016-07-04 21:12 ` [PATCH 08/10] clk: sunxi: make clk-* " Paul Gortmaker
2016-07-04 21:36 ` Boris Brezillon
2016-07-05 6:13 ` Maxime Ripard
2016-07-06 22:22 ` Michael Turquette
2016-07-04 21:12 ` [PATCH 09/10] clk: tegra: make clk-tegra124-dfll-fcpu " Paul Gortmaker
2016-11-04 20:33 ` Stephen Boyd
2016-07-04 21:12 ` Paul Gortmaker [this message]
2016-11-04 20:35 ` [PATCH 10/10] clk: ti: make clk-dra7-atl " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704211220.5685-11-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.ujfalusi@ti.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).