From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Rob Herring <robh@kernel.org>
Cc: <lee.jones@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <broonie@kernel.org>,
<linus.walleij@linaro.org>, <mark.rutland@arm.com>,
<lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
<linux-clk@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v5 3/8] clk: lochnagar: Add initial binding documentation
Date: Tue, 27 Nov 2018 09:34:24 +0000 [thread overview]
Message-ID: <20181127093424.GR16508@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181126201645.GA2094@bogus>
On Mon, Nov 26, 2018 at 02:16:45PM -0600, Rob Herring wrote:
> On Tue, Nov 20, 2018 at 02:16:26PM +0000, Charles Keepax wrote:
> > Lochnagar is an evaluation and development board for Cirrus
> > Logic Smart CODEC and Amp devices. It allows the connection of
> > most Cirrus Logic devices on mini-cards, as well as allowing
> > connection of various application processor systems to provide a
> > full evaluation platform. This driver supports the board
> > controller chip on the Lochnagar board.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > + - compatible : One of the following strings:
> > + "cirrus,lochnagar1-clk"
> > + "cirrus,lochnagar2-clk"
>
> What's the 1 vs. 2?
>
There are two versions of the device, we need to be able to
differenciate between them in the driver.
> > + - ln-pmic-32k : On board fixed regulator.
>
> regulator?
Well that is a spectacular copy and paste oversight sorry about
that will get it fixed up.
>
> > + - ln-clk-12m : On board fixed regulator.
> > + - ln-clk-11m : On board fixed regulator.
> > + - ln-clk-24m : On board fixed regulator.
> > + - ln-clk-22m : On board fixed regulator.
> > + - ln-usb-clk-24m : On board fixed regulator.
> > + - ln-usb-clk-12m : On board fixed regulator.
> > +lochnagar-clk {
> > + compatible = "cirrus,lochnagar2-clk";
> > +
> > + #clock-cells = <1>;
> > +
> > + clocks = <&clk-audio>, <&clk_pmic>;
> > + clock-names = "ln-gf-mclk2", "ln-pmic-32k";
> > +
> > + assigned-clocks = <&lochnagar-clk LOCHNAGAR_CDC_MCLK1>,
> > + <&lochnagar-clk LOCHNAGAR_CDC_MCLK2>;
> > + assigned-clock-parents = <&clk-audio>,
> > + <&clk-pmic>;
> > +
> > + clk-pmic: clk-pmic {
>
> This isn't really any relationship to the parent and I think shouldn't
> be a sub-node.
>
Yeah sorry that is a good point will move it out.
Thanks,
Charles
next prev parent reply other threads:[~2018-11-27 9:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:16 [PATCH v5 1/8] regulator: lochnagar: Move driver to binding from DT Charles Keepax
2018-11-20 14:16 ` [PATCH v5 2/8] mfd: lochnagar: Add initial binding documentation Charles Keepax
2018-11-28 9:18 ` Lee Jones
2018-11-20 14:16 ` [PATCH v5 3/8] clk: " Charles Keepax
2018-11-26 20:16 ` Rob Herring
2018-11-27 9:34 ` Charles Keepax [this message]
2018-11-20 14:16 ` [PATCH v5 4/8] pinctrl: " Charles Keepax
2018-12-07 17:07 ` Rob Herring
2018-12-16 0:16 ` Linus Walleij
2018-11-20 14:16 ` [PATCH v5 5/8] regulator: " Charles Keepax
2018-11-20 14:16 ` [PATCH v5 6/8] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar Charles Keepax
2018-11-23 9:00 ` kbuild test robot
2018-11-23 9:15 ` Charles Keepax
2018-11-28 9:22 ` Lee Jones
2018-11-20 14:16 ` [PATCH v5 7/8] clk: " Charles Keepax
2018-11-30 7:53 ` Stephen Boyd
2018-12-21 13:50 ` Charles Keepax
2018-12-21 15:28 ` Charles Keepax
2018-12-21 20:44 ` Stephen Boyd
2018-11-20 14:16 ` [PATCH v5 8/8] pinctrl: " Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127093424.GR16508@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).