From: Andreas Kemnade <andreas@kemnade.info>
To: Stephen Boyd <sboyd@kernel.org>
Cc: bcousson@baylibre.com, letux-kernel@openphoenux.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, mturquette@baylibre.com,
paul@pwsan.com, t-kristo@ti.com, tony@atomide.com
Subject: Re: [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops
Date: Fri, 30 Nov 2018 07:15:34 +0100 [thread overview]
Message-ID: <20181130071534.0a6cd455@kemnade.info> (raw)
In-Reply-To: <154353750560.88331.11814738542436183126@swboyd.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]
Hi Stephen,
On Thu, 29 Nov 2018 16:25:05 -0800
Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Andreas Kemnade (2018-11-10 12:31:14)
> > Code might use autoidle api with clocks not being omap2 clocks,
> > so check if clock type is not basic
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > New in v2
> > ---
> > drivers/clk/ti/autoidle.c | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/ti/autoidle.c b/drivers/clk/ti/autoidle.c
> > index 161f67850393..5bdae5552d38 100644
> > --- a/drivers/clk/ti/autoidle.c
> > +++ b/drivers/clk/ti/autoidle.c
> > @@ -54,8 +54,12 @@ static DEFINE_SPINLOCK(autoidle_spinlock);
> > int omap2_clk_deny_idle(struct clk *clk)
> > {
> > struct clk_hw_omap *c;
> > + struct clk_hw *hw = __clk_get_hw(clk);
> >
> > - c = to_clk_hw_omap(__clk_get_hw(clk));
> > + if (clk_hw_get_flags(hw) & CLK_IS_BASIC)
>
> Please try to avoid using CLK_IS_BASIC if at all possible. Can you?
> Maybe add some flag in clk_hw_omap() instead?
>
hmm, Tero suggested that.
But to check flags in clk_hw_omap I first need to know that there is a
clk_hw_omap behind clk_hw. And for that I either need to check flags in
clk_hw or do more changes in the omap_hwmod code.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-30 6:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 20:31 [PATCH v2 0/3] mach-omap2: handle autoidle denial Andreas Kemnade
2018-11-10 20:31 ` [PATCH v2 1/3] clk: ti: add a usecount for autoidle Andreas Kemnade
2018-11-10 20:31 ` [PATCH v2 2/3] clk: ti: check clock type before doing autoidle ops Andreas Kemnade
2018-11-30 0:25 ` Stephen Boyd
2018-11-30 6:15 ` Andreas Kemnade [this message]
2018-11-30 7:20 ` Stephen Boyd
2018-11-30 7:35 ` Tero Kristo
2018-11-30 7:57 ` Stephen Boyd
2018-11-30 9:20 ` Tero Kristo
2018-11-30 12:17 ` Andreas Kemnade
2018-11-30 15:37 ` Tony Lindgren
2018-11-30 23:51 ` Stephen Boyd
2018-12-03 15:39 ` Tony Lindgren
2018-12-03 16:22 ` Andreas Kemnade
2018-12-04 16:45 ` Tony Lindgren
2018-12-27 20:12 ` Andreas Kemnade
2018-12-28 20:02 ` Tony Lindgren
2018-12-31 7:23 ` Tero Kristo
2018-12-31 8:30 ` Andreas Kemnade
2019-01-03 23:39 ` Stephen Boyd
2019-01-04 7:28 ` Tero Kristo
2019-01-11 22:49 ` Stephen Boyd
2019-01-14 8:25 ` Tero Kristo
2018-12-03 17:06 ` Stephen Boyd
2018-11-10 20:31 ` [PATCH v2 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that Andreas Kemnade
2018-11-30 0:26 ` [PATCH v2 0/3] mach-omap2: handle autoidle denial Stephen Boyd
2018-11-30 7:37 ` Tero Kristo
2018-11-30 7:57 ` Stephen Boyd
2018-11-30 9:21 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130071534.0a6cd455@kemnade.info \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).