From: Shawn Guo <shawnguo@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>, Lucas Stach <l.stach@pengutronix.de>
Cc: Stephen Boyd <sboyd@kernel.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Olof Johansson <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Rob Herring <robh@kernel.org>,
Will Deacon <will.deacon@arm.com>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH 1/3] arm64: Remove CONFIG_SOC_IMX8MQ and use ARCH_MXC instead
Date: Fri, 14 Dec 2018 09:12:09 +0800 [thread overview]
Message-ID: <20181214011207.GB13243@dragon> (raw)
In-Reply-To: <20181213145149.6hyyhi6hxdzvikl4@fsr-ub1664-175>
On Thu, Dec 13, 2018 at 02:51:50PM +0000, Abel Vesa wrote:
...
> > > diff --git a/arch/arm64/Kconfig.platforms
> > > b/arch/arm64/Kconfig.platforms
> > > index 7e1545a..318dbb9 100644
> > > --- a/arch/arm64/Kconfig.platforms
> > > +++ b/arch/arm64/Kconfig.platforms
> > > @@ -148,14 +148,6 @@ config ARCH_MXC
> > > This enables support for the ARMv8 based SoCs in the
> > > NXP i.MX family.
> > >
> > > -config SOC_IMX8MQ
> > > - bool "i.MX8MQ support"
> > > - depends on ARCH_MXC
> > > - select ARM64_ERRATUM_843419
> > > - select ARM64_ERRATUM_845719
> > > - help
> > > - This enables support for the i.MX8MQ SoC.
> > > -
> >
> > NACK on this one. Having a single place where stuff that is absolutely
> > critical for proper SoC operation can be selected is very useful and
> > avoids hard to debug issues due to slightly wrong configs in the long
> > run.
>
> As mentioned in the cover letter, please ignore this patch set entirely.
> The ARCH_MXC is actually used on arm32 too, so it won't work.
>
> I'm working on a patchset that will add the Kconfig into
> drivers/clk/imx/ and in it will add CLK_IMX8MQ. That will
> fix the clock dependency since the CLK_IMX8MQ will depend on
> ARCH_MXC and ARM64. I believe the CLK_IMX8QXP will follow
> the same pattern.
>
> As for the SOC_IMX8MQ, all the other vendors have one single
> config for all the arm64 platforms. TBH, to control every SoC
> independently it's a little bit of an overkill.
Lucas,
We are still waiting for further comments from Olof [1]. But it sounds
like SoC specific option is not welcomed on ARM64.
Shawn
[1] https://patchwork.kernel.org/patch/10727453/#22378669
next prev parent reply other threads:[~2018-12-14 1:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 13:17 [PATCH 0/3] i.MX8MQ build dependency fixes Abel Vesa
2018-12-13 13:17 ` [PATCH 1/3] arm64: Remove CONFIG_SOC_IMX8MQ and use ARCH_MXC instead Abel Vesa
2018-12-13 14:35 ` Lucas Stach
2018-12-13 14:51 ` Abel Vesa
2018-12-14 1:12 ` Shawn Guo [this message]
2018-12-14 9:22 ` Lucas Stach
2018-12-14 12:41 ` Abel Vesa
2018-12-14 17:16 ` Stephen Boyd
2018-12-13 13:17 ` [PATCH 2/3] clk: imx: Build imx8mq clocks on arm64 only Abel Vesa
2018-12-13 13:24 ` Aisheng Dong
2018-12-13 13:17 ` [PATCH 3/3] arm64: Add i.MX8 boot necesarry configs to defconfig Abel Vesa
2018-12-13 13:22 ` [PATCH 0/3] i.MX8MQ build dependency fixes Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214011207.GB13243@dragon \
--to=shawnguo@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).