From: Abel Vesa <abel.vesa@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers
Date: Mon, 17 Dec 2018 11:35:40 +0000 [thread overview]
Message-ID: <20181217113539.nfwp4knbx3luxoqn@fsr-ub1664-175> (raw)
In-Reply-To: <154482171780.19322.123667425822315496@swboyd.mtv.corp.google.com>
On 18-12-14 13:08:37, Stephen Boyd wrote:
> Quoting Abel Vesa (2018-12-14 07:30:08)
> > This is mainly to shut up the checkpatch.pl script warnings about the
> > "static const char *" needing to be "static const char * const".
> >
> > Abel Vesa (3):
> > clk: imx: Make parent_names const pointer in composite-8m
> > clk: imx: Make parents const pointer in mux wrappers
> > clk: imx8mq: Make parent names arrays const pointers
> >
>
> I still see warnings though so there seems to be some more work to do.
>
> drivers/clk/imx/clk-imx8mq.c:401:89: warning: passing argument 5 of 'imx_clk_mux2' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> clks[IMX8MQ_CLK_GPU_SHADER_SRC] = imx_clk_mux2("gpu_shader_src", base + 0x8200, 24, 3, imx8mq_gpu_shader_sels, ARRAY_SIZE(imx8mq_gpu_shader_sels));
>
Hmm, I guess you applied this on top of clk-imx8mq, right ?
This change is against linux-next. The actual problem is the imx_clk_mux2
which looks like this on branch clk-imx8mq:
static inline struct clk *imx_clk_mux2(const char *name, void __iomem *reg,
u8 shift, u8 width, const char **parents, int num_parents)
but it looks like this on linux-next (which is exactly the same on clk-next):
static inline struct clk *imx_clk_mux2(const char *name, void __iomem *reg,
u8 shift, u8 width, const char * const *parents,
int num_parents)
next prev parent reply other threads:[~2018-12-17 11:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 15:30 [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers Abel Vesa
2018-12-14 15:30 ` [PATCH 1/3] clk: imx: Make parent_names const pointer in composite-8m Abel Vesa
2019-01-09 19:02 ` Stephen Boyd
2018-12-14 15:30 ` [PATCH 2/3] clk: imx: Make parents const pointer in mux wrappers Abel Vesa
2019-01-09 19:02 ` Stephen Boyd
2018-12-14 15:30 ` [PATCH 3/3] clk: imx8mq: Make parent names arrays const pointers Abel Vesa
2019-01-09 19:02 ` Stephen Boyd
2018-12-14 21:08 ` [PATCH 0/3] clk: imx: Make all the parent_names arrays be " Stephen Boyd
2018-12-17 11:35 ` Abel Vesa [this message]
2018-12-17 18:40 ` Stephen Boyd
2018-12-17 18:59 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217113539.nfwp4knbx3luxoqn@fsr-ub1664-175 \
--to=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).