Hi Yixun, Thank you for the patch! Yet something to improve: [auto build test ERROR on clk/clk-next] [also build test ERROR on next-20181217] [cannot apply to v4.20-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jianxin-Pan/clk-meson-add-one-based-divider-support-for-sclk-divider/20181218-021139 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All error/warnings (new ones prefixed by >>): In file included from include/linux/cache.h:5:0, from include/linux/printk.h:9, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/io.h:23, from include/linux/clk-provider.h:9, from drivers/clk//meson/clk-phase-delay.c:13: drivers/clk//meson/clk-phase-delay.c: In function 'meson_clk_phase_delay_get_phase': >> drivers/clk//meson/clk-phase-delay.c:33:40: warning: integer overflow in expression [-Woverflow] period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, ^ include/uapi/linux/kernel.h:13:40: note: in definition of macro '__KERNEL_DIV_ROUND_UP' #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) ^ >> drivers/clk//meson/clk-phase-delay.c:33:14: note: in expansion of macro 'DIV_ROUND_UP' period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, ^~~~~~~~~~~~ drivers/clk//meson/clk-phase-delay.c: In function 'meson_clk_phase_delay_set_phase': drivers/clk//meson/clk-phase-delay.c:50:40: warning: integer overflow in expression [-Woverflow] period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, clk_hw_get_rate(hw)); ^ include/uapi/linux/kernel.h:13:40: note: in definition of macro '__KERNEL_DIV_ROUND_UP' #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) ^ drivers/clk//meson/clk-phase-delay.c:50:14: note: in expansion of macro 'DIV_ROUND_UP' period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, clk_hw_get_rate(hw)); ^~~~~~~~~~~~ In file included from ./arch/sh/include/generated/asm/div64.h:1:0, from include/linux/kernel.h:207, from include/asm-generic/bug.h:18, from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/io.h:23, from include/linux/clk-provider.h:9, from drivers/clk//meson/clk-phase-delay.c:13: include/asm-generic/div64.h:222:28: warning: comparison of distinct pointer types lacks a cast (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ ^ >> drivers/clk//meson/clk-phase-delay.c:56:6: note: in expansion of macro 'do_div' r = do_div(degrees, 360 / 1 << (ph->phase.width)); ^~~~~~ In file included from include/linux/init.h:5:0, from include/linux/io.h:22, from include/linux/clk-provider.h:9, from drivers/clk//meson/clk-phase-delay.c:13: include/asm-generic/div64.h:235:25: warning: right shift count >= width of type [-Wshift-count-overflow] } else if (likely(((n) >> 32) == 0)) { \ ^ include/linux/compiler.h:76:40: note: in definition of macro 'likely' # define likely(x) __builtin_expect(!!(x), 1) ^ >> drivers/clk//meson/clk-phase-delay.c:56:6: note: in expansion of macro 'do_div' r = do_div(degrees, 360 / 1 << (ph->phase.width)); ^~~~~~ In file included from ./arch/sh/include/generated/asm/div64.h:1:0, from include/linux/kernel.h:207, from include/asm-generic/bug.h:18, from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/io.h:23, from include/linux/clk-provider.h:9, from drivers/clk//meson/clk-phase-delay.c:13: >> include/asm-generic/div64.h:239:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types] __rem = __div64_32(&(n), __base); \ ^ >> drivers/clk//meson/clk-phase-delay.c:56:6: note: in expansion of macro 'do_div' r = do_div(degrees, 360 / 1 << (ph->phase.width)); ^~~~~~ include/asm-generic/div64.h:213:17: note: expected 'uint64_t * {aka long long unsigned int *}' but argument is of type 'int *' extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor); ^~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/cache.h:5:0, from include/linux/printk.h:9, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/io.h:23, from include/linux/clk-provider.h:9, from drivers/clk/meson/clk-phase-delay.c:13: drivers/clk/meson/clk-phase-delay.c: In function 'meson_clk_phase_delay_get_phase': drivers/clk/meson/clk-phase-delay.c:33:40: warning: integer overflow in expression [-Woverflow] period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, ^ include/uapi/linux/kernel.h:13:40: note: in definition of macro '__KERNEL_DIV_ROUND_UP' #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) ^ drivers/clk/meson/clk-phase-delay.c:33:14: note: in expansion of macro 'DIV_ROUND_UP' period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, ^~~~~~~~~~~~ drivers/clk/meson/clk-phase-delay.c: In function 'meson_clk_phase_delay_set_phase': drivers/clk/meson/clk-phase-delay.c:50:40: warning: integer overflow in expression [-Woverflow] period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, clk_hw_get_rate(hw)); ^ include/uapi/linux/kernel.h:13:40: note: in definition of macro '__KERNEL_DIV_ROUND_UP' #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) ^ drivers/clk/meson/clk-phase-delay.c:50:14: note: in expansion of macro 'DIV_ROUND_UP' period_ps = DIV_ROUND_UP(NSEC_PER_SEC * 1000, clk_hw_get_rate(hw)); ^~~~~~~~~~~~ In file included from ./arch/sh/include/generated/asm/div64.h:1:0, from include/linux/kernel.h:207, from include/asm-generic/bug.h:18, from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/io.h:23, from include/linux/clk-provider.h:9, from drivers/clk/meson/clk-phase-delay.c:13: include/asm-generic/div64.h:222:28: warning: comparison of distinct pointer types lacks a cast (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ ^ drivers/clk/meson/clk-phase-delay.c:56:6: note: in expansion of macro 'do_div' r = do_div(degrees, 360 / 1 << (ph->phase.width)); ^~~~~~ In file included from include/linux/init.h:5:0, from include/linux/io.h:22, from include/linux/clk-provider.h:9, from drivers/clk/meson/clk-phase-delay.c:13: include/asm-generic/div64.h:235:25: warning: right shift count >= width of type [-Wshift-count-overflow] } else if (likely(((n) >> 32) == 0)) { \ ^ include/linux/compiler.h:76:40: note: in definition of macro 'likely' # define likely(x) __builtin_expect(!!(x), 1) ^ drivers/clk/meson/clk-phase-delay.c:56:6: note: in expansion of macro 'do_div' r = do_div(degrees, 360 / 1 << (ph->phase.width)); ^~~~~~ In file included from ./arch/sh/include/generated/asm/div64.h:1:0, from include/linux/kernel.h:207, from include/asm-generic/bug.h:18, from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/io.h:23, from include/linux/clk-provider.h:9, from drivers/clk/meson/clk-phase-delay.c:13: >> include/asm-generic/div64.h:239:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types] __rem = __div64_32(&(n), __base); \ ^ drivers/clk/meson/clk-phase-delay.c:56:6: note: in expansion of macro 'do_div' r = do_div(degrees, 360 / 1 << (ph->phase.width)); ^~~~~~ include/asm-generic/div64.h:213:17: note: expected 'uint64_t * {aka long long unsigned int *}' but argument is of type 'int *' extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor); ^~~~~~~~~~ cc1: some warnings being treated as errors vim +/__div64_32 +239 include/asm-generic/div64.h ^1da177e Linus Torvalds 2005-04-16 215 ^1da177e Linus Torvalds 2005-04-16 216 /* The unnecessary pointer compare is there ^1da177e Linus Torvalds 2005-04-16 217 * to check for type safety (n must be 64bit) ^1da177e Linus Torvalds 2005-04-16 218 */ ^1da177e Linus Torvalds 2005-04-16 219 # define do_div(n,base) ({ \ ^1da177e Linus Torvalds 2005-04-16 220 uint32_t __base = (base); \ ^1da177e Linus Torvalds 2005-04-16 221 uint32_t __rem; \ ^1da177e Linus Torvalds 2005-04-16 222 (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \ 911918aa Nicolas Pitre 2015-11-02 223 if (__builtin_constant_p(__base) && \ 911918aa Nicolas Pitre 2015-11-02 224 is_power_of_2(__base)) { \ 911918aa Nicolas Pitre 2015-11-02 225 __rem = (n) & (__base - 1); \ 911918aa Nicolas Pitre 2015-11-02 226 (n) >>= ilog2(__base); \ 461a5e51 Nicolas Pitre 2015-10-30 227 } else if (__div64_const32_is_OK && \ 461a5e51 Nicolas Pitre 2015-10-30 228 __builtin_constant_p(__base) && \ 461a5e51 Nicolas Pitre 2015-10-30 229 __base != 0) { \ 461a5e51 Nicolas Pitre 2015-10-30 230 uint32_t __res_lo, __n_lo = (n); \ 461a5e51 Nicolas Pitre 2015-10-30 231 (n) = __div64_const32(n, __base); \ 461a5e51 Nicolas Pitre 2015-10-30 232 /* the remainder can be computed with 32-bit regs */ \ 461a5e51 Nicolas Pitre 2015-10-30 233 __res_lo = (n); \ 461a5e51 Nicolas Pitre 2015-10-30 234 __rem = __n_lo - __res_lo * __base; \ 911918aa Nicolas Pitre 2015-11-02 235 } else if (likely(((n) >> 32) == 0)) { \ ^1da177e Linus Torvalds 2005-04-16 236 __rem = (uint32_t)(n) % __base; \ ^1da177e Linus Torvalds 2005-04-16 237 (n) = (uint32_t)(n) / __base; \ ^1da177e Linus Torvalds 2005-04-16 238 } else \ ^1da177e Linus Torvalds 2005-04-16 @239 __rem = __div64_32(&(n), __base); \ ^1da177e Linus Torvalds 2005-04-16 240 __rem; \ ^1da177e Linus Torvalds 2005-04-16 241 }) ^1da177e Linus Torvalds 2005-04-16 242 :::::: The code at line 239 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation