On Sat, Jan 26, 2019 at 09:39:00PM +0530, Jagan Teki wrote: > On 25/01/19 9:22 PM, Maxime Ripard wrote: > > On Fri, Jan 25, 2019 at 01:28:52AM +0530, Jagan Teki wrote: > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > > > > > But unlike A33, A64 doesn't have DSI_SCLK gating which eventually > > > set the mod clock rate for the controller. > > > > > > So, use the DSI_DPHY gating for the similar purpose of mod clock > > > so-that the controller can operate properly. > > > > > > Signed-off-by: Jagan Teki > > > Reviewed-by: Rob Herring > > > --- > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > index 69e233e8fad1..dbda2e567760 100644 > > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > > @@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. > > > Required properties: > > > - compatible: value must be one of: > > > * allwinner,sun6i-a31-mipi-dsi > > > + * "allwinner,sun50i-a64-mipi-dsi", "allwinner,sun6i-a31-mipi-dsi" > > > > The other line doesn't have quotes, we should be consistent > > You mean to say, remove quotes like this > > allwinner,sun50i-a64-mipi-dsi, allwinner,sun6i-a31-mipi-dsi Yep > This make confusion with comma with allwinner vs next compatible string > isn't it? (In fact I did follow the similar like TCON in sun4i-drm.txt) There's no really clear consensus here, andd i don't really have a strong opinion on the matter either. Since the YAML schemas are going to have it without double quotes, I guess we should use that convention as well, but we want to remain consistent at least. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com