From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Rob Herring <robh@kernel.org>
Cc: mazziesaccount@gmail.com, heikki.haikola@fi.rohmeurope.com,
mikko.mutanen@fi.rohmeurope.com, lee.jones@linaro.org,
mark.rutland@arm.com, broonie@kernel.org,
gregkh@linuxfoundation.org, rafael@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
sre@kernel.org, lgirdwood@gmail.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, wim@linux-watchdog.org,
linux@roeck-us.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [RFC PATCH v3 06/10] devicetree: bindings: Document first ROHM BD70528 bindings
Date: Thu, 31 Jan 2019 08:40:51 +0200 [thread overview]
Message-ID: <20190131064050.GC23791@localhost.localdomain> (raw)
In-Reply-To: <20190130185344.GA14789@bogus>
Hello Rob,
Thanks for taking the carefull look once again =)
On Wed, Jan 30, 2019 at 12:53:44PM -0600, Rob Herring wrote:
> On Wed, Jan 30, 2019 at 11:09:55AM +0200, Matti Vaittinen wrote:
> > Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> > drivers) and 4 GPIO pins which can be configured for I/O or
> > as interrupt sources withe configurable trigger levels.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > .../devicetree/bindings/mfd/rohm,bd70528-pmic.txt | 104 +++++++++++++++++++++
snip
> > + - interrupt-parent : Phandle to the parent interrupt controller.
>
> Don't document this. It is implied and could be in a parent node.
Allright. I'll remove this then.
> > + - clock-frequency : Should be 32768
>
> Forget to drop this?
Well spotted. The rate should come from parent clock. I'll drop this
too.
> > +Example:
> > +/* external oscillator */
> > +osc: oscillator {
> > + compatible = "fixed-clock";
> > + #clock-cells = <1>;
> > + clock-frequency = <32768>;
> > + clock-output-names = "osc";
> > +};
> > +
> > +pmic: bd70528@4b {
>
> pmic@4b
>
> Node names should be generic.
Ok. I will change this.
Br,
Matti
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
next prev parent reply other threads:[~2019-01-31 6:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 9:05 [RFC PATCH v3 00/10] support ROHM BD70528 PMIC Matti Vaittinen
2019-01-30 9:06 ` [RFC PATCH v3 01/10] mfd: bd718x7.h split to ROHM common and bd718x7 specific parts Matti Vaittinen
2019-01-30 9:07 ` [RFC PATCH v3 02/10] regulator: bd718x7 use chip specific and generic data structs Matti Vaittinen
2019-01-30 9:08 ` [RFC PATCH v3 03/10] clk: bd718x7: " Matti Vaittinen
2019-01-30 9:08 ` [RFC PATCH v3 04/10] mfd: bd70528: Support ROHM bd70528 PMIC - core Matti Vaittinen
2019-01-30 9:09 ` [RFC PATCH v3 05/10] clk: bd718x7: Support ROHM BD70528 clk block Matti Vaittinen
2019-01-30 9:09 ` [RFC PATCH v3 06/10] devicetree: bindings: Document first ROHM BD70528 bindings Matti Vaittinen
2019-01-30 18:53 ` Rob Herring
2019-01-31 6:40 ` Matti Vaittinen [this message]
2019-01-30 9:11 ` [RFC PATCH v3 07/10] gpio: Initial support for ROHM bd70528 GPIO block Matti Vaittinen
2019-01-30 9:12 ` [RFC PATCH v3 08/10] rtc: bd70528: Initial support for ROHM bd70528 RTC Matti Vaittinen
2019-01-31 10:48 ` Alexandre Belloni
2019-01-30 9:16 ` [RFC PATCH v3 09/10] power: supply: Initial support for ROHM BD70528 PMIC charger block Matti Vaittinen
2019-01-30 9:22 ` [RFC PATCH v3 10/10] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131064050.GC23791@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.haikola@fi.rohmeurope.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=mturquette@baylibre.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).