From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: mazziesaccount@gmail.com, corbet@lwn.net, cw00.choi@samsung.com,
krzk@kernel.org, b.zolnierkie@samsung.com,
mturquette@baylibre.com, sboyd@kernel.org, linux@armlinux.org.uk,
pombredanne@nexb.com, sre@kernel.org, vkoul@kernel.org,
linux@roeck-us.net, pavel@ucw.cz, sjhuang@iluvatar.ai,
andrew.smirnov@gmail.com, djkurtz@chromium.org,
akshu.agrawal@amd.com, rafael.j.wysocki@intel.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 0/3] clk: clkdev add managed lookup registrations
Date: Thu, 31 Jan 2019 15:24:52 +0200 [thread overview]
Message-ID: <20190131132452.GD23791@localhost.localdomain> (raw)
In-Reply-To: <cover.1544177090.git.matti.vaittinen@fi.rohmeurope.com>
Hello All,
On Fri, Dec 07, 2018 at 01:09:00PM +0200, Matti Vaittinen wrote:
> Series adds managed clkdev lookup interfaces and cleans few drivers
>
> Few clk drivers appear to be leaking clkdev lookup registrations at
> driver remove. The patch series adds devm versions of lookup
> registrations and cleans up few drivers. Driver clean-up patches have
> not been tested as I lack the HW. All testing and comments if
> driver/device removal is even possible for changed drivers is highly
> appreciated. If removal is not possible I will gladly drop the patches
> from series - although leaking lookups may serve as bad example for new
> developers =)
>
> Changed drivers are:
> clk-max77686 and clk-st
>
> Please note that the patch #2 requires this change to work correctly:
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=05502bf9eb7a7297f5fa6f1d17b169b3d5b53570
I guess the dependency mentioned abowe is already in (most) of the
trees. (I can't say for sure as I don't know what is the correct tree
for clkdev - is it linux-arm.git as Russel is maintaining clkdev? If
yes, then the commit 05502bf9eb7a7297f5fa6f1d17b169b3d5b53570
"clk: of-provider: look at parent if registered device has no
provider info" seems to be sitting in maser branch).
So should I rebase this series to some other tree and resend? Or is this
something that is not wanted?
Br,
Matti Vaittinen
next prev parent reply other threads:[~2019-01-31 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 11:09 [PATCH v7 0/3] clk: clkdev add managed lookup registrations Matti Vaittinen
2018-12-07 11:09 ` [PATCH v7 1/3] clkdev: add managed clkdev lookup registration Matti Vaittinen
2019-02-06 19:05 ` Stephen Boyd
2018-12-07 11:10 ` [PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2019-02-06 19:05 ` Stephen Boyd
2018-12-07 11:10 ` [PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2019-02-06 19:05 ` Stephen Boyd
2019-01-31 13:24 ` Matti Vaittinen [this message]
2019-01-31 15:21 ` [PATCH v7 0/3] clk: clkdev add managed lookup registrations Russell King - ARM Linux admin
2019-01-31 19:38 ` Stephen Boyd
2019-02-01 8:40 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131132452.GD23791@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=akshu.agrawal@amd.com \
--cc=andrew.smirnov@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=cw00.choi@samsung.com \
--cc=djkurtz@chromium.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sboyd@kernel.org \
--cc=sjhuang@iluvatar.ai \
--cc=sre@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).