From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Mesih Kilinc <mesihkilinc@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>,
Linus Walleij <linus.walleij@linaro.org>,
Icenowy Zheng <icenowy@aosc.io>, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 6/7] ARM: dts: suniv: Add pinmux for SPI0 and SPI1 of F1C100s
Date: Mon, 11 Feb 2019 16:51:52 +0100 [thread overview]
Message-ID: <20190211155152.gnocoojqa27fmeay@flea> (raw)
In-Reply-To: <37f573797e18fc22f8f78d0a62550b6d5e460a8d.1549875778.git.mesihkilinc@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
On Mon, Feb 11, 2019 at 12:21:12PM +0300, Mesih Kilinc wrote:
> PC0~PC4 is pin group for SPI0. PA0~PA4 is pin group for SPI1.
> Add device tree nodes for this groups.
>
> Signed-off-by: Mesih Kilinc <mesihkilinc@gmail.com>
> ---
> arch/arm/boot/dts/suniv-f1c100s.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi b/arch/arm/boot/dts/suniv-f1c100s.dtsi
> index 1b332d9..a92a411 100644
> --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi
> +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi
> @@ -96,6 +96,16 @@
> pins = "PE0", "PE1";
> function = "uart0";
> };
> +
> + spi0_pc_pins: spi0-pc-pins {
> + pins = "PC0", "PC1", "PC2", "PC3";
> + function = "spi0";
> + };
> +
> + spi1_pa_pins: spi1-pa-pins {
> + pins = "PA0", "PA1", "PA2", "PA3";
> + function = "spi1";
> + };
Are they the only options for the muxing of the SPI pins? if so, you'd
need to remove the pin bank, and to set the pinctrl-0 and
pinctrl-names in the DTSI.
We also move the CS pin out in a separate group to accomodate devices
that use a GPIO instead.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-02-11 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 9:21 [PATCH 0/7] Timer & SPI support for Allwinner suniv F1C100s Mesih Kilinc
2019-02-11 9:21 ` [PATCH 1/7] dt-bindings: timer: Add Allwinner suniv timer Mesih Kilinc
2019-02-11 9:21 ` [PATCH 2/7] clocksource: sun4i: add a compatible for suniv Mesih Kilinc
2019-02-11 9:21 ` [PATCH 3/7] ARM: dts: suniv: Add dt-binding headers for F1C100s Mesih Kilinc
2019-02-11 9:21 ` [PATCH 4/7] dt-bindings: spi: Add Support for Allwinner F1C100s Mesih Kilinc
2019-02-25 23:33 ` Rob Herring
2019-02-11 9:21 ` [PATCH 5/7] ARM: dts: suniv: Add SPI device-tree nodes Mesih Kilinc
2019-02-11 9:21 ` [PATCH 6/7] ARM: dts: suniv: Add pinmux for SPI0 and SPI1 of F1C100s Mesih Kilinc
2019-02-11 15:51 ` Maxime Ripard [this message]
2019-02-11 9:21 ` [PATCH 7/7] ARM: dts: f1c100s: Activate SPI flash on Lichee Pi Nano Mesih Kilinc
2019-03-17 17:39 ` [PATCH 0/7] Timer & SPI support for Allwinner suniv F1C100s Icenowy Zheng
2019-03-17 20:52 ` Daniel Lezcano
2019-03-18 7:18 ` Icenowy Zheng
2019-03-18 8:04 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211155152.gnocoojqa27fmeay@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mesihkilinc@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).