From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D85C10F04 for ; Fri, 15 Feb 2019 02:35:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FCEF21927 for ; Fri, 15 Feb 2019 02:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550198106; bh=XX8gkTWfydJ2h2LV3tckAphKi35817hiwi8/g5LwD/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uN57LHX8LummJSDgCHa/SVNW7eBZpZvaj3jZAqR4X+14oyM7zFi0KhhdxzVVXcJ/Q ugXBmJDtOKCtZgJ87DyPT1OXqyDVOqmdKRKxyEES649KvtCAxkeUTlk1vPk/+RZzTi MGNMx9YjevcM8PpzqUxqoLwBOVElk590J5RGglgs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390801AbfBOCLb (ORCPT ); Thu, 14 Feb 2019 21:11:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:51546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390794AbfBOCLb (ORCPT ); Thu, 14 Feb 2019 21:11:31 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF732222D4; Fri, 15 Feb 2019 02:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196690; bh=XX8gkTWfydJ2h2LV3tckAphKi35817hiwi8/g5LwD/U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pLDb1UuuMqNzNV1vdUQlFLgVr4ojm8T5O3fBDCd+Hkxjo6fBGVUYCQI2VY5w+YlSz T0LksEaBe9VfVTpYWWsxjpftDpg+JZ/raBeAkmVTr2jZRaoSIbwBaDQfyprlSYi9Hl 4b1vsVaZL3ZUm/GEGOapyxv/OH/QN4/fwy1rFeAY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Stephen Boyd , Sasha Levin , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 05/65] clk: tegra: dfll: Fix a potential Oop in remove() Date: Thu, 14 Feb 2019 21:10:21 -0500 Message-Id: <20190215021121.177674-5-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215021121.177674-1-sashal@kernel.org> References: <20190215021121.177674-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org From: Dan Carpenter [ Upstream commit d39eca547f3ec67140a5d765a426eb157b978a59 ] If tegra_dfll_unregister() fails then "soc" is an error pointer. We should just return instead of dereferencing it. Fixes: 1752c9ee23fb ("clk: tegra: dfll: Fix drvdata overwriting issue") Signed-off-by: Dan Carpenter Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c index 269d3595758b..edc31bb56674 100644 --- a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c +++ b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c @@ -133,9 +133,11 @@ static int tegra124_dfll_fcpu_remove(struct platform_device *pdev) struct tegra_dfll_soc_data *soc; soc = tegra_dfll_unregister(pdev); - if (IS_ERR(soc)) + if (IS_ERR(soc)) { dev_err(&pdev->dev, "failed to unregister DFLL: %ld\n", PTR_ERR(soc)); + return PTR_ERR(soc); + } tegra_cvb_remove_opp_table(soc->dev, soc->cvb, soc->max_freq); -- 2.19.1