From: Thierry Reding <thierry.reding@gmail.com>
To: arm@kernel.org
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
"\\ Peter De Schrijver" <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Joseph Lo <josephl@nvidia.com>,
linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] clk: tegra: dfll: Make symbol 'tegra210_cpu_cvb_tables' static
Date: Mon, 18 Feb 2019 09:38:58 +0100 [thread overview]
Message-ID: <20190218083858.GA19363@ulmo> (raw)
In-Reply-To: <20190218070609.167535-1-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 2040 bytes --]
On Mon, Feb 18, 2019 at 07:06:09AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/clk/tegra/clk-tegra124-dfll-fcpu.c:244:18: warning:
> symbol 'tegra210_cpu_cvb_tables' was not declared. Should it be static?
>
> Fixes: 2b2dbc2f94e5 ("clk: tegra: dfll: add CVB tables for Tegra210")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ARM SoC maintainers,
This fixes a sparse warning introduced in the tegra-for-5.1-clk pull
request that you pulled last week. Do you want me to send you another
pull request (perhaps give it a few more days in case other fixes are
going to show up) or would you rather apply this directly?
In the latter case, here's a link to patchwork:
http://patchwork.ozlabs.org/patch/1043804/
and this is:
Acked-by: Thierry Reding <treding@nvidia.com>
In the meantime, I'll go and improve my build scripts to run sparse as
well. I used to do that but then removed it again because it was so
noisy that it was impossible to filter out the Tegra-specific bits. I
wonder if I could do something like have the build scripts build the
branch base first, without sparse checking, and then fast-forward to the
branch head and build again with sparse checking enabled. That way I
should only be seeing the sparse results for code that was modified in
the branch.
Thierry
> diff --git a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c
> index 4b6dd2b3767f..e8ec42bf8638 100644
> --- a/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c
> +++ b/drivers/clk/tegra/clk-tegra124-dfll-fcpu.c
> @@ -241,7 +241,7 @@ static const unsigned long tegra210_cpu_max_freq_table[] = {
> { 0UL, { 0, 0, 0 } }, \
> }
>
> -struct cvb_table tegra210_cpu_cvb_tables[] = {
> +static struct cvb_table tegra210_cpu_cvb_tables[] = {
> {
> .speedo_id = 10,
> .process_id = 0,
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-18 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 7:06 [PATCH -next] clk: tegra: dfll: Make symbol 'tegra210_cpu_cvb_tables' static Wei Yongjun
2019-02-18 8:38 ` Thierry Reding [this message]
2019-02-18 10:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218083858.GA19363@ulmo \
--to=thierry.reding@gmail.com \
--cc=arm@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=sboyd@kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).