From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCH 0/4] Prepare Armada 3700 PCIe suspend to RAM support
Date: Mon, 25 Feb 2019 16:05:35 +0100 [thread overview]
Message-ID: <20190225160535.3395c680@xps13> (raw)
In-Reply-To: <20181123094444.27956-1-miquel.raynal@bootlin.com>
Hi Stephen,
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Fri, 23 Nov 2018
10:44:39 +0100:
> Hello,
>
> As part of an effort to bring suspend to RAM support to the Armada
> 3700 SoC (main target: ESPRESSObin board), there are small things to
> do in the Armada 3700 peripherals clock driver:
>
> * On this SoC, the PCIe controller gets fed by a gated clock in the
> south bridge. This clock is missing in the current driver, patch 1
> adds it.
>
> * Because of a constraint in the PCI core, the resume function of a
> PCIe controller driver must be run at an early stage
> (->suspend/resume_noirq()), before the core tries to ->read/write()
> in the PCIe registers to do more configuration. Hence, the PCIe
> clock must be resumed before. This is enforced thanks to two
> changes:
> 1/ Add device links to the clock framework. This enforce order in
> the PM core: the clocks are resumed before the consumers. Series
> has been posted, see [1].
> 2/ Even with the above feature, the clock's resume() callback is
> called after the PCI controller's resume_noirq() callback. The
> only way to fix this is to change the "priority" of the clock
> suspend/resume callbacks. This is done in patch 2.
>
> * The bindings are updated with the PCI clock in patch 4 while patch 3
> is just a typo correction in the same file.
>
> If there is anything unclear please feel free to ask.
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/614527.html
This series does not depend on the clock device links work so I
wonder if you are still considering it?
Thanks,
Miquèl
prev parent reply other threads:[~2019-02-25 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 9:44 [PATCH 0/4] Prepare Armada 3700 PCIe suspend to RAM support Miquel Raynal
2018-11-23 9:44 ` [PATCH 1/4] clk: mvebu: armada-37xx-periph: add PCIe gated clock Miquel Raynal
2018-11-23 9:44 ` [PATCH 2/4] clk: mvebu: armada-37xx-periph: change suspend/resume time Miquel Raynal
2018-11-30 0:37 ` Stephen Boyd
2018-11-30 10:58 ` Miquel Raynal
2018-12-12 21:59 ` Bjorn Helgaas
2019-01-11 13:44 ` Miquel Raynal
2018-11-23 9:44 ` [PATCH 3/4] dt-bindings: clk: armada3700: fix typo in SoC name Miquel Raynal
2018-12-11 21:35 ` Rob Herring
2018-11-23 9:44 ` [PATCH 4/4] dt-bindings: clk: armada3700: document the PCIe clock Miquel Raynal
2018-12-11 21:36 ` Rob Herring
2019-02-25 15:05 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225160535.3395c680@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).