From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6013BC48BD5 for ; Tue, 25 Jun 2019 14:10:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FB022146E for ; Tue, 25 Jun 2019 14:10:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728878AbfFYOKb (ORCPT ); Tue, 25 Jun 2019 10:10:31 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58235 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727251AbfFYOKb (ORCPT ); Tue, 25 Jun 2019 10:10:31 -0400 X-Originating-IP: 90.88.16.156 Received: from localhost (aaubervilliers-681-1-41-156.w90-88.abo.wanadoo.fr [90.88.16.156]) (Authenticated sender: maxime.ripard@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6653940003; Tue, 25 Jun 2019 14:10:26 +0000 (UTC) Date: Tue, 25 Jun 2019 16:10:25 +0200 From: Maxime Ripard To: Linus Walleij Cc: Icenowy Zheng , Rob Herring , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "linux-kernel@vger.kernel.org" , linux-clk , "open list:GPIO SUBSYSTEM" , linux-sunxi Subject: Re: [PATCH v3 1/9] pinctrl: sunxi: v3s: introduce support for V3 Message-ID: <20190625141025.uvewl7arnsz5grr3@flea> References: <20190623043801.14040-1-icenowy@aosc.io> <20190623043801.14040-2-icenowy@aosc.io> <20190624124019.o6acnnkjikekshl5@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uh3numobk6gzuc5u" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --uh3numobk6gzuc5u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 25, 2019 at 03:57:15PM +0200, Linus Walleij wrote: > On Mon, Jun 24, 2019 at 2:40 PM Maxime Ripard wrote: > > On Sun, Jun 23, 2019 at 12:37:53PM +0800, Icenowy Zheng wrote: > > > Introduce the GPIO pins that is only available on V3 (not on V3s) to the > > > V3s pinctrl driver. > > > > > > Signed-off-by: Icenowy Zheng > > > --- > > > Changes in v3: > > > - Fixed code alignment. > > > - Fixed LVDS function number. > > > > - SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > - SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > + SUNXI_FUNCTION(0x2, "uart2"), /* TX */ > > > + SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 0)), /* PB_EINT0 */ > > > > I'm not sure why all that churn is needed. > > > > Looks good otherwise. > > Should I apply the patch or wait for a new version without the > whitespace fixes? I'd rather not have the indentation changes in that patch. And we've sent the changes for 5.3 already, so it's going to be 5.4 material anyway. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --uh3numobk6gzuc5u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXRIrUQAKCRDj7w1vZxhR xUx/APwJxRclTo/OlevMmcYPGQ1p1ck7FN1SUXrdShcLFeCyjwD/Y20Bm5HFxJ74 8AikfrRhA+M905RT/a5BkSxvJYhOeg0= =yyVJ -----END PGP SIGNATURE----- --uh3numobk6gzuc5u--