From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6057FC32751 for ; Wed, 31 Jul 2019 19:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32096214DA for ; Wed, 31 Jul 2019 19:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564601752; bh=HfN2MQysfM/pLD5DmbpZ0LVsnJDMstZJe8ye/rK0+DQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EpP4jHmRGSlIvB3SeNCQylxzrjVC2wUMYigtgLNf195DJMb+YkAkpWJa1dqeCFNKY NYQgKJPVrTLu4m61AZ6Ivky9gQiSy3qZLHNkq5Kb6ZMmLeZ3SzGgdSVfzvwXkG09tx 3+sEsDnlMoOTHnOPf6wKMePizyIY68H/z0dK+lJM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731067AbfGaTfr (ORCPT ); Wed, 31 Jul 2019 15:35:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:34876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729737AbfGaTfV (ORCPT ); Wed, 31 Jul 2019 15:35:21 -0400 Received: from mail.kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B23B4217D7; Wed, 31 Jul 2019 19:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564601720; bh=HfN2MQysfM/pLD5DmbpZ0LVsnJDMstZJe8ye/rK0+DQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L7Yrh/vXryB3bAXc1CeV3+7xXmKVJOrb7RdSzBnKcrQk3zCAqWM8DXukbpi6MUXR6 GN8I9zssC2xz55HDCiKSuJIzeqj6pcvQ0d6itfiRCk48OUY/Ln+eiuitXntGp95Ul7 6gmNP47EnDr4iCHM935am3Xh3zQvhS70M9RqqKf4= From: Stephen Boyd To: Michael Turquette , Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Chunyan Zhang , Baolin Wang Subject: [PATCH 7/9] clk: sprd: Don't reference clk_init_data after registration Date: Wed, 31 Jul 2019 12:35:15 -0700 Message-Id: <20190731193517.237136-8-sboyd@kernel.org> X-Mailer: git-send-email 2.22.0.709.g102302147b-goog In-Reply-To: <20190731193517.237136-1-sboyd@kernel.org> References: <20190731193517.237136-1-sboyd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org A future patch is going to change semantics of clk_register() so that clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid referencing this member here so that we don't run into NULL pointer exceptions. Cc: Chunyan Zhang Cc: Baolin Wang Signed-off-by: Stephen Boyd --- Please ack so I can take this through clk tree drivers/clk/sprd/common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index a5bdca1de5d0..9d56eac43832 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -76,16 +76,17 @@ int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw) struct clk_hw *hw; for (i = 0; i < clkhw->num; i++) { + const char *name; hw = clkhw->hws[i]; - if (!hw) continue; + name = hw->init->name; ret = devm_clk_hw_register(dev, hw); if (ret) { dev_err(dev, "Couldn't register clock %d - %s\n", - i, hw->init->name); + i, name); return ret; } } -- Sent by a computer through tubes