From: Stephen Boyd <sboyd@kernel.org>
To: Jonas Gorski <jonas.gorski@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Michael Turquette <mturquette@baylibre.com>,
Philippe Mathieu-Daud?? <f4bug@amsat.org>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings
Date: Thu, 08 Aug 2019 12:48:20 -0700 [thread overview]
Message-ID: <20190808194821.825AD21743@mail.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1908081809160.2995@hadrien>
Quoting Julia Lawall (2019-08-08 09:10:53)
> From: kbuild test robot <lkp@intel.com>
>
> drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together.
>
> Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
>
> Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver")
Is it fixing anything? As far as I can tell it's reducing lines of code
with another function.
> CC: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
next prev parent reply other threads:[~2019-08-08 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:10 [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings Julia Lawall
2019-08-08 19:48 ` Stephen Boyd [this message]
2019-08-08 19:51 ` Julia Lawall
2019-09-06 17:30 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808194821.825AD21743@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=f4bug@amsat.org \
--cc=jonas.gorski@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).