On Thu, Aug 08, 2019 at 04:46:46PM -0700, Sowjanya Komatineni wrote: > This patch adds an API clk_hw_get_parent_index to get index of the > clock parent to use during the clock restore operations on system > resume. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/clk/clk.c | 17 +++++++++++++++++ > include/linux/clk-provider.h | 1 + > 2 files changed, 18 insertions(+) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index c0990703ce54..f26252e48f73 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -1643,6 +1643,23 @@ static int clk_fetch_parent_index(struct clk_core *core, > return i; > } > > +/** > + * clk_hw_get_parent_index - return the index of parent clock > + * @hw: clk_hw associated with the clk being consumed > + * @parent_hw: clk_hw associated with the parent of clk > + * > + * Fetches and returns the index of parent clock. > + * if hw or parent_hw is NULL, returns -EINVAL. "If" because it's at the beginning of a sentence. You may also want to turn this into a "Return:" section as described in: Documentation/doc-guide/kernel-doc.rst That said, other functions in this file don't use that construct either, so I suppose this is fine as-is, for consistency. So with the capitalization of "If" fixed, this is: Reviewed-by: Thierry Reding