From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819D8C433FF for ; Tue, 13 Aug 2019 18:30:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44F8620679 for ; Tue, 13 Aug 2019 18:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565721007; bh=AAcWpHX1c7OqZ19H2TdUwNCGoFLrr2xzn4NIMWe0y44=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=IltFLNOR2ut4flHvNsw9mNkXoPYM52PkGoq/MT4ou/Dbn15qCeue6V0NKjr2zlvqr soJnrsvPg0FDIn0spiRBu5cHIwA74I0vHRN6vqQPkkbtpKjza9AbQycdeANZs6EJpt KQHhcJThWu/O6O0hU79Mkn8mEK0IpsTKkUpx9gt0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728287AbfHMSaH (ORCPT ); Tue, 13 Aug 2019 14:30:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:34044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727665AbfHMSaG (ORCPT ); Tue, 13 Aug 2019 14:30:06 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC13020665; Tue, 13 Aug 2019 18:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565721006; bh=AAcWpHX1c7OqZ19H2TdUwNCGoFLrr2xzn4NIMWe0y44=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ZD4kJjWF9zQida/HMKAddKmuo9zEQdOPO37S8s5/sUd1LWthRKkIajhZ66u8bpanS RTZrj8U5otptn0n9ai1fr0Hd/2lw8MGUsKmeZE5ThRjJxWxvRvNlbiNnrfw55zMPKO SK5TtOJgU/kjcV+OlTJRCpEGozqo1BaX4DZt6nWI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190812100216.34459-1-wen.he_1@nxp.com> References: <20190812100216.34459-1-wen.he_1@nxp.com> Subject: Re: [v1 2/3] dt/bindings: clk: Add DT bindings for LS1028A Display output interface From: Stephen Boyd Cc: leoyang.li@nxp.com, liviu.dudau@arm.com, Wen He To: Mark Rutland , Michael Turquette , Rob Herring , Shawn Guo , Wen He , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: alot/0.8.1 Date: Tue, 13 Aug 2019 11:30:05 -0700 Message-Id: <20190813183005.EC13020665@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Wen He (2019-08-12 03:02:16) > diff --git a/Documentation/devicetree/bindings/clock/fsl,plldig.txt b/Doc= umentation/devicetree/bindings/clock/fsl,plldig.txt > new file mode 100644 > index 000000000000..29c5a6117809 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/fsl,plldig.txt > @@ -0,0 +1,26 @@ > +NXP QorIQ Layerscape LS1028A Display output interface Clock > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Can you convert this to YAML? > + > +Required properties: > + - compatible: shall contain "fsl,ls1028a-plldig" > + - reg: Physical base address and size of the block registers > + - #clock-cells: shall contain 1. As I said in the previous patch, this should probably be 0. Also, please order this before the driver in the patch series and thread your messages please. If you use git-send-email this is done for you pretty easily. > + - clocks: a phandle + clock-specifier pairs, here should be > + specify the reference clock of the system > + > +