From: Stephen Boyd <sboyd@kernel.org>
To: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-devel@linux.nxdi.nxp.com" <linux-devel@linux.nxdi.nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
Leo Li <leoyang.li@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Wen He <wen.he_1@nxp.com>
Subject: RE: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock driver for Display output interface
Date: Wed, 14 Aug 2019 10:27:11 -0700 [thread overview]
Message-ID: <20190814172712.7F8F6206C1@mail.kernel.org> (raw)
In-Reply-To: <DB7PR04MB51955595AB182A80162E313AE2AD0@DB7PR04MB5195.eurprd04.prod.outlook.com>
Quoting Wen He (2019-08-14 02:38:21)
>
>
> > -----Original Message-----
> > From: Stephen Boyd <sboyd@kernel.org>
> > Sent: 2019年8月14日 2:25
> > To: Michael Turquette <mturquette@baylibre.com>; Wen He
> > <wen.he_1@nxp.com>; Leo Li <leoyang.li@nxp.com>;
> > linux-clk@vger.kernel.org; linux-devel@linux.nxdi.nxp.com;
> > linux-kernel@vger.kernel.org; liviu.dudau@arm.com
> > Cc: Wen He <wen.he_1@nxp.com>
> > Subject: [EXT] Re: [v1 1/3] clk: ls1028a: Add clock driver for Display output
> > interface
> >
> >
> > Quoting Wen He (2019-08-12 03:01:03)
> > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index
> > > 801fa1cd0321..0e6c7027d637 100644
> > > --- a/drivers/clk/Kconfig
> > > +++ b/drivers/clk/Kconfig
> > > @@ -223,6 +223,15 @@ config CLK_QORIQ
> > > This adds the clock driver support for Freescale QorIQ platforms
> > > using common clock framework.
> > >
> > > +config CLK_PLLDIG
> > > + bool "Clock driver for LS1028A Display output"
> > > + depends on ARCH_LAYERSCAPE && OF
> >
> > Does it actually depend on either of these to build? Probabl not, so maybe just
> > default ARCH_LAYERSCAPE && OF? Also, can your Kconfig variable be named
> > something more specific like CLK_LS1028A_PLLDIG?
>
> Actually it also depends Display modules, but we allow building display drivers as modules,
> so is here whether need add Display modules depend and also allow clock driver building
> to a module?
> Would it be better to reduce the number of the modules insert, I think the clock driver
> should be long available for the system.
I'm asking if it actually requires ARCH_LAYERSCAPE or OF to successfully
compile the file. Is that true? I don't see any asm/ includes or
anything that's going to fail if either of these configs aren't enabled.
So it seems safe to change this to
depends on ARCH_LAYERSCAPE || COMPILE_TEST
default ARCH_LAYERSCAPE
so that it's compiled by default on this architecture and is available
to be compile tested by various test builders.
>
> looks like great if named Kconfig variable to 'CLK_LS1028A_PLLDIG'.
>
> >
next prev parent reply other threads:[~2019-08-14 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 10:01 [v1 1/3] clk: ls1028a: Add clock driver for Display output interface Wen He
2019-08-13 18:25 ` Stephen Boyd
2019-08-14 9:38 ` [EXT] " Wen He
2019-08-14 17:27 ` Stephen Boyd [this message]
2019-08-15 4:47 ` Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814172712.7F8F6206C1@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-devel@linux.nxdi.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=mturquette@baylibre.com \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).