From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A74C3A59C for ; Fri, 16 Aug 2019 14:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D87B2171F for ; Fri, 16 Aug 2019 14:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565967058; bh=5bjMuPNKlGhcpAlzNw9BbBUAmfscWvJrM/Ab4JVnF/I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=YBm/U2CTjFN7bDPZhOWd/7aLL7ZSMVtfmbr/J1iUVG/LkhoIIqnEtItqtEwihNhHZ S7e+7Dk0lzobLtD7cg30W0rjxzpuNq1dRHe3Ngq5kud25HJu6lvJaML8GQHWYtfMNT nlZVdIsq5hVGtHnT5hlU5Ay0L+HufrZiduRUZmi8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbfHPOu5 (ORCPT ); Fri, 16 Aug 2019 10:50:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:55252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbfHPOu5 (ORCPT ); Fri, 16 Aug 2019 10:50:57 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82726206C1; Fri, 16 Aug 2019 14:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565967056; bh=5bjMuPNKlGhcpAlzNw9BbBUAmfscWvJrM/Ab4JVnF/I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=P13FrS9B+WOoVno+4GbcAPulL6EukbeVd816XDzOuycGgZnycNBf1x4SDcWUA+s24 VyiuQo1CKkM8Ege4hJPlwBDJSv7LMzH2ogHsduzAsiy0NvPqTPPmB51hMj2pgaInN1 Vs59tFL0fgkG99thDSJiaeRp7kP5MYEJg759rZ5A= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190816112210.GA27094@mani> References: <20190731193517.237136-1-sboyd@kernel.org> <20190731193517.237136-2-sboyd@kernel.org> <20190816112210.GA27094@mani> Subject: Re: [PATCH 1/9] clk: actions: Don't reference clk_init_data after registration From: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org To: Manivannan Sadhasivam User-Agent: alot/0.8.1 Date: Fri, 16 Aug 2019 07:50:55 -0700 Message-Id: <20190816145056.82726206C1@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Manivannan Sadhasivam (2019-08-16 04:22:10) > On Wed, Jul 31, 2019 at 12:35:09PM -0700, Stephen Boyd wrote: > > A future patch is going to change semantics of clk_register() so that > > clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid > > referencing this member here so that we don't run into NULL pointer > > exceptions. > >=20 > > Cc: Manivannan Sadhasivam > > Signed-off-by: Stephen Boyd > > --- > >=20 > > Please ack so I can take this through clk tree > >=20 > > drivers/clk/actions/owl-common.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/clk/actions/owl-common.c b/drivers/clk/actions/owl= -common.c > > index 32dd29e0a37e..71b683c4e643 100644 > > --- a/drivers/clk/actions/owl-common.c > > +++ b/drivers/clk/actions/owl-common.c > > @@ -68,6 +68,7 @@ int owl_clk_probe(struct device *dev, struct clk_hw_o= necell_data *hw_clks) > > struct clk_hw *hw; > > =20 > > for (i =3D 0; i < hw_clks->num; i++) { > > + const char *name =3D hw->init->name; > > =20 >=20 > This should come after below statement and hence the warning is generated > in linux-next. Sorry for missing! >=20 Oh right. Will fix it.