From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4230C3A59C for ; Fri, 16 Aug 2019 17:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF1CD21726 for ; Fri, 16 Aug 2019 17:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565977175; bh=Hkql629r7jMcpDCSxxQyeYY9VUfj+ahusqlu9yDMvrc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=AU4yXKWfZtqniEGDdMbxS5htkUjfp7P0egCMuOYgrNOCIb67Zl62u+ZK7hXXcZ8l/ Fl3p7sq/Eq401wkkEWDw1UmMdKF3zvLbL1VHxlCi7f/KsFfhr36stf6gy9DeHEAV4I DP28BOCDGVUhI4YJxHUOC2OBgMQ+aigtzmgB9KDg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfHPRjf (ORCPT ); Fri, 16 Aug 2019 13:39:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727347AbfHPRjf (ORCPT ); Fri, 16 Aug 2019 13:39:35 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60509205F4; Fri, 16 Aug 2019 17:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565977174; bh=Hkql629r7jMcpDCSxxQyeYY9VUfj+ahusqlu9yDMvrc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=VEUKX1woF1+HKNWJy9m1xpe3/2wVZkOVt6mzeKpwGagd4EEyDFFQ5aIFPPYudf/u9 WI2YjhZvHidzvy2iHc7gwEzPwnYeshMTHPpS6vQTqDNKa9bvgvUbXaZ201A9ru/0LT SnNpM1nc4HKDqE1dego2rca6fTLJ1bh6niL07Rho= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1565713248-4906-7-git-send-email-wahrenst@gmx.net> References: <1565713248-4906-1-git-send-email-wahrenst@gmx.net> <1565713248-4906-7-git-send-email-wahrenst@gmx.net> Subject: Re: [PATCH V2 06/13] clk: bcm2835: Mark PLLD_PER as CRITICAL From: Stephen Boyd Cc: bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, Stefan Wahren To: Eric Anholt , Florian Fainelli , Mark Rutland , Michael Turquette , Ray Jui , Rob Herring , Scott Branden , Stefan Wahren , Wolfram Sang User-Agent: alot/0.8.1 Date: Fri, 16 Aug 2019 10:39:33 -0700 Message-Id: <20190816173934.60509205F4@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Stefan Wahren (2019-08-13 09:20:41) > The VPU firmware assume that the PLLD_PER isn't modified by the ARM core. > Otherwise this could cause firmware lookups. So mark the clock as critical > to avoid this. >=20 > Signed-off-by: Stefan Wahren > --- > drivers/clk/bcm/clk-bcm2835.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index fdf672a..b62052e 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array= [] =3D { > .load_mask =3D CM_PLLD_LOADPER, > .hold_mask =3D CM_PLLD_HOLDPER, > .fixed_divider =3D 1, > - .flags =3D CLK_SET_RATE_PARENT), > + .flags =3D CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), Please add a comment in the code to the effect that is in the commit text so we don't have to dig through commits to figure out why this special CLK_IS_CRITICAL flag is here. > [BCM2835_PLLD_DSI0] =3D REGISTER_PLL_DIV( > SOC_ALL, > .name =3D "plld_dsi0",