From: Tony Lindgren <tony@atomide.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Adam Ford" <aford173@gmail.com>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"moaz korena" <moaz@korena.xyz>,
"Merlijn Wajer" <merlijn@wizzup.org>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
"Philipp Rossak" <embed3d@gmail.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Tero Kristo" <t-kristo@ti.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/6] ARM: dts: Configure sgx for omap5
Date: Mon, 26 Aug 2019 07:55:30 -0700 [thread overview]
Message-ID: <20190826145530.GT52127@atomide.com> (raw)
In-Reply-To: <20190817065615.GI52127@atomide.com>
* Tony Lindgren <tony@atomide.com> [190817 06:56]:
> * Stephen Boyd <sboyd@kernel.org> [190815 18:24]:
> > Quoting Tony Lindgren (2019-08-14 06:14:06)
> > > diff --git a/arch/arm/boot/dts/omap54xx-clocks.dtsi b/arch/arm/boot/dts/omap54xx-clocks.dtsi
> > > --- a/arch/arm/boot/dts/omap54xx-clocks.dtsi
> > > +++ b/arch/arm/boot/dts/omap54xx-clocks.dtsi
> > > @@ -1146,6 +1146,20 @@
> > > };
> > > };
> > >
> > > + gpu_cm: gpu_cm@1500 {
> >
> > Node names shouldn't have underscores. Maybe clock-controller?
>
> OK yeah clock-controller sounds good to me.
Below is this one updated to use clock-controller naming.
Regards,
Tony
8< ---------------------------
From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 14 Aug 2019 05:18:16 -0700
Subject: [PATCH] ARM: dts: Configure sgx for omap5
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
I've tested that the interconnect target module enables and idles
just fine when probed with ti-sysc with PM runtime control via sys:
# echo on > $(find /sys -name control | grep \/5600)
# rwmem 0x5600fe00 # OCP Revision
0x5600fe00 = 0x40000000
# echo auto > $(find /sys -name control | grep \/5600)
# rwmem 0x5600fe10
# rwmem 0x56000024
Cc: Adam Ford <aford173@gmail.com>
Cc: Filip Matijević <filip.matijevic.pz@gmail.com>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: moaz korena <moaz@korena.xyz>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
Cc: Philipp Rossak <embed3d@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/boot/dts/omap5.dtsi | 23 +++++++++++++++++++++++
arch/arm/boot/dts/omap54xx-clocks.dtsi | 14 ++++++++++++++
2 files changed, 37 insertions(+)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -257,6 +257,29 @@
ports-implemented = <0x1>;
};
+ target-module@56000000 {
+ compatible = "ti,sysc-omap4", "ti,sysc";
+ reg = <0x5600fe00 0x4>,
+ <0x5600fe10 0x4>;
+ reg-names = "rev", "sysc";
+ ti,sysc-midle = <SYSC_IDLE_FORCE>,
+ <SYSC_IDLE_NO>,
+ <SYSC_IDLE_SMART>;
+ ti,sysc-sidle = <SYSC_IDLE_FORCE>,
+ <SYSC_IDLE_NO>,
+ <SYSC_IDLE_SMART>;
+ clocks = <&gpu_clkctrl OMAP5_GPU_CLKCTRL 0>;
+ clock-names = "fck";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x56000000 0x2000000>;
+
+ /*
+ * Closed source PowerVR driver, no child device
+ * binding or driver in mainline
+ */
+ };
+
dss: dss@58000000 {
compatible = "ti,omap5-dss";
reg = <0x58000000 0x80>;
diff --git a/arch/arm/boot/dts/omap54xx-clocks.dtsi b/arch/arm/boot/dts/omap54xx-clocks.dtsi
--- a/arch/arm/boot/dts/omap54xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap54xx-clocks.dtsi
@@ -1146,6 +1146,20 @@
};
};
+ gpu_cm: clock-controller@1500 {
+ compatible = "ti,omap4-cm";
+ reg = <0x1500 0x100>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x1500 0x100>;
+
+ gpu_clkctrl: clk@20 {
+ compatible = "ti,clkctrl";
+ reg = <0x20 0x4>;
+ #clock-cells = <2>;
+ };
+ };
+
l3init_cm: l3init_cm@1600 {
compatible = "ti,omap4-cm";
reg = <0x1600 0x100>;
--
2.23.0
next prev parent reply other threads:[~2019-08-26 14:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 13:14 [PATCH 0/6] Configure sgx interconnect data for some omap variants Tony Lindgren
2019-08-14 13:14 ` [PATCH 1/6] ARM: OMAP2+: Drop legacy platform data for omap4 gpu Tony Lindgren
2019-08-14 13:14 ` [PATCH 2/6] bus: ti-sysc: Add module enable quirk for SGX on omap36xx Tony Lindgren
2019-08-14 13:14 ` [PATCH 3/6] clk: ti: add clkctrl data omap5 sgx Tony Lindgren
2019-08-14 13:14 ` [PATCH 4/6] ARM: dts: Configure sgx for omap5 Tony Lindgren
[not found] ` <20190815182348.8A1BA2063F@mail.kernel.org>
2019-08-17 6:56 ` Tony Lindgren
2019-08-26 14:55 ` Tony Lindgren [this message]
2019-09-05 15:03 ` H. Nikolaus Schaller
2019-09-05 15:28 ` Tony Lindgren
2019-10-05 16:20 ` H. Nikolaus Schaller
2019-08-14 13:14 ` [PATCH 5/6] ARM: dts: Configure interconnect target module for omap3 sgx Tony Lindgren
2019-08-14 14:46 ` Andrew F. Davis
2019-08-19 19:12 ` Adam Ford
2019-09-07 11:51 ` H. Nikolaus Schaller
2019-08-14 13:14 ` [PATCH 6/6] ARM: dts: Configure rstctrl reset for SGX Tony Lindgren
2019-09-13 9:49 ` H. Nikolaus Schaller
2019-09-16 15:17 ` Tony Lindgren
2019-09-16 18:04 ` Tony Lindgren
2019-09-16 18:12 ` H. Nikolaus Schaller
2019-09-16 19:15 ` H. Nikolaus Schaller
2019-09-16 19:20 ` Adam Ford
2019-09-16 19:45 ` H. Nikolaus Schaller
2019-08-14 19:13 ` [PATCH 0/6] Configure sgx interconnect data for some omap variants Adam Ford
2019-08-15 4:02 ` Tony Lindgren
2019-08-15 4:15 ` Tony Lindgren
2019-08-15 13:05 ` Adam Ford
2019-08-17 7:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826145530.GT52127@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=embed3d@gmail.com \
--cc=filip.matijevic.pz@gmail.com \
--cc=hns@goldelico.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=moaz@korena.xyz \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).