From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B4FC43331 for ; Fri, 6 Sep 2019 17:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73E3320693 for ; Fri, 6 Sep 2019 17:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567789634; bh=D11z4GUDpq/JdT/cpzm/Kangl1whlU3Xiur0T0XShRE=; h=In-Reply-To:References:To:From:Cc:Subject:Date:List-ID:From; b=qudQuRvq/iNsaFRZUToj1E3yaolV6j5tWlHXmjb0wVVJxBOnSMogrQvtHkpwXp04f OKhe4f792M2gdtRQhG0TiTgtCnu9L5NZaIkcEEjYGLVwCTt8K3sPs6THowAmKlb/e/ UT8dIYmRAqIbWCtFjHODVrH6Rl7N1erb+UbNnjzM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405919AbfIFRHO (ORCPT ); Fri, 6 Sep 2019 13:07:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:58946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730223AbfIFRHO (ORCPT ); Fri, 6 Sep 2019 13:07:14 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81A1A20578; Fri, 6 Sep 2019 17:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567789633; bh=D11z4GUDpq/JdT/cpzm/Kangl1whlU3Xiur0T0XShRE=; h=In-Reply-To:References:To:From:Cc:Subject:Date:From; b=j3KWnfQ36jWrgIhToQXSTZ4O/HzhKbLmzgJ5KOV8GemUUu1x7FD8GusSInpC4Uswd MDxMBAU5Jk9A8GRJ36TUM76zExcqBYzyMM0+h+/xC7ZBHCKykX4qNsNZVzaEOL6QmV tnlL4V3XBjKcmj/MCZNvNqxFuaQsGbxMVreB3O9g= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1566299605-15641-5-git-send-email-aisheng.dong@nxp.com> References: <1566299605-15641-1-git-send-email-aisheng.dong@nxp.com> <1566299605-15641-5-git-send-email-aisheng.dong@nxp.com> To: Dong Aisheng , linux-clk@vger.kernel.org From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, mturquette@baylibre.com, shawnguo@kernel.org, fabio.estevam@nxp.com, linux-imx@nxp.com, kernel@pengutronix.de, Dong Aisheng Subject: Re: [PATCH V4 04/11] clk: imx: scu: bypass cpu power domains User-Agent: alot/0.8.1 Date: Fri, 06 Sep 2019 10:07:12 -0700 Message-Id: <20190906170713.81A1A20578@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Dong Aisheng (2019-08-20 04:13:18) > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c > index 48bfb08..5f935b1 100644 > --- a/drivers/clk/imx/clk-scu.c > +++ b/drivers/clk/imx/clk-scu.c > @@ -479,6 +479,10 @@ static int imx_clk_scu_attach_pd(struct device *dev,= u32 rsrc_id) > .args[0] =3D rsrc_id, > }; > =20 > + if ((rsrc_id =3D=3D IMX_SC_R_A35) || (rsrc_id =3D=3D IMX_SC_R_A53= ) || > + (rsrc_id =3D=3D IMX_SC_R_A72)) Please drop the extra parenthesis. It makes it hard to read. > + return 0; > + > return of_genpd_add_device(&genpdspec, dev);