* [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
@ 2019-09-06 4:56 Vinod Koul
2019-09-06 19:55 ` Bjorn Andersson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Vinod Koul @ 2019-09-06 4:56 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Taniya Das,
Andy Gross, Michael Turquette, linux-clk, linux-kernel
Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
dont want the clock rates to do round up.
[1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/clk/qcom/gcc-qcs404.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index e12c04c09a6a..bd32212f37e6 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
.name = "sdcc1_apps_clk_src",
.parent_names = gcc_parent_names_13,
.num_parents = 5,
- .ops = &clk_rcg2_ops,
+ .ops = &clk_rcg2_floor_ops,
},
};
@@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = {
.name = "sdcc2_apps_clk_src",
.parent_names = gcc_parent_names_14,
.num_parents = 4,
- .ops = &clk_rcg2_ops,
+ .ops = &clk_rcg2_floor_ops,
},
};
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
2019-09-06 4:56 [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks Vinod Koul
@ 2019-09-06 19:55 ` Bjorn Andersson
2019-09-06 20:38 ` Stephen Boyd
2019-09-09 10:25 ` Stephen Boyd
2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2019-09-06 19:55 UTC (permalink / raw)
To: Vinod Koul
Cc: Stephen Boyd, linux-arm-msm, Taniya Das, Andy Gross,
Michael Turquette, linux-clk, linux-kernel
On Thu 05 Sep 21:56 PDT 2019, Vinod Koul wrote:
> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
> dont want the clock rates to do round up.
>
> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/clk/qcom/gcc-qcs404.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> index e12c04c09a6a..bd32212f37e6 100644
> --- a/drivers/clk/qcom/gcc-qcs404.c
> +++ b/drivers/clk/qcom/gcc-qcs404.c
> @@ -1057,7 +1057,7 @@ static struct clk_rcg2 sdcc1_apps_clk_src = {
> .name = "sdcc1_apps_clk_src",
> .parent_names = gcc_parent_names_13,
> .num_parents = 5,
> - .ops = &clk_rcg2_ops,
> + .ops = &clk_rcg2_floor_ops,
> },
> };
>
> @@ -1103,7 +1103,7 @@ static struct clk_rcg2 sdcc2_apps_clk_src = {
> .name = "sdcc2_apps_clk_src",
> .parent_names = gcc_parent_names_14,
> .num_parents = 4,
> - .ops = &clk_rcg2_ops,
> + .ops = &clk_rcg2_floor_ops,
> },
> };
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
2019-09-06 4:56 [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks Vinod Koul
2019-09-06 19:55 ` Bjorn Andersson
@ 2019-09-06 20:38 ` Stephen Boyd
2019-09-07 7:48 ` Vinod Koul
2019-09-09 7:48 ` Taniya Das
2019-09-09 10:25 ` Stephen Boyd
2 siblings, 2 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-09-06 20:38 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Taniya Das,
Andy Gross, Michael Turquette, linux-clk, linux-kernel
Quoting Vinod Koul (2019-09-05 21:56:59)
> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
> dont want the clock rates to do round up.
>
> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
Is Taniya writing the rest? Please don't dribble it out over the next
few weeks!
> drivers/clk/qcom/gcc-qcs404.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
2019-09-06 20:38 ` Stephen Boyd
@ 2019-09-07 7:48 ` Vinod Koul
2019-09-09 7:48 ` Taniya Das
1 sibling, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2019-09-07 7:48 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-arm-msm, Bjorn Andersson, Taniya Das, Andy Gross,
Michael Turquette, linux-clk, linux-kernel
On 06-09-19, 13:38, Stephen Boyd wrote:
> Quoting Vinod Koul (2019-09-05 21:56:59)
> > Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
> > disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
> > dont want the clock rates to do round up.
> >
> > [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
>
> Is Taniya writing the rest? Please don't dribble it out over the next
> few weeks!
Taniya is Cced. Since I upstream qcs404 driver and have a board handy to
test, did that :)
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
2019-09-06 20:38 ` Stephen Boyd
2019-09-07 7:48 ` Vinod Koul
@ 2019-09-09 7:48 ` Taniya Das
2019-09-09 10:24 ` Stephen Boyd
1 sibling, 1 reply; 7+ messages in thread
From: Taniya Das @ 2019-09-09 7:48 UTC (permalink / raw)
To: Stephen Boyd, Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Andy Gross, Michael Turquette,
linux-clk, linux-kernel
Hi Stephen, Vinod,
On 9/7/2019 2:08 AM, Stephen Boyd wrote:
> Quoting Vinod Koul (2019-09-05 21:56:59)
>> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
>> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
>> dont want the clock rates to do round up.
>>
>> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
>>
>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>> ---
>
> Is Taniya writing the rest? Please don't dribble it out over the next
> few weeks!
I have pushed the patch : https://patchwork.kernel.org/patch/11137393/
Vinod, I have taken care of the QCS404 in the same patch, so as to keep
the change in one patch.
>
>> drivers/clk/qcom/gcc-qcs404.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
2019-09-09 7:48 ` Taniya Das
@ 2019-09-09 10:24 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-09-09 10:24 UTC (permalink / raw)
To: Taniya Das, Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Andy Gross, Michael Turquette,
linux-clk, linux-kernel
Quoting Taniya Das (2019-09-09 00:48:39)
> Hi Stephen, Vinod,
>
> On 9/7/2019 2:08 AM, Stephen Boyd wrote:
> > Quoting Vinod Koul (2019-09-05 21:56:59)
> >> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
> >> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
> >> dont want the clock rates to do round up.
> >>
> >> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
> >>
> >> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> >> ---
> >
> > Is Taniya writing the rest? Please don't dribble it out over the next
> > few weeks!
>
> I have pushed the patch : https://patchwork.kernel.org/patch/11137393/
>
> Vinod, I have taken care of the QCS404 in the same patch, so as to keep
> the change in one patch.
>
Cool thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks
2019-09-06 4:56 [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks Vinod Koul
2019-09-06 19:55 ` Bjorn Andersson
2019-09-06 20:38 ` Stephen Boyd
@ 2019-09-09 10:25 ` Stephen Boyd
2 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2019-09-09 10:25 UTC (permalink / raw)
To: Vinod Koul
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Taniya Das,
Andy Gross, Michael Turquette, linux-clk, linux-kernel
Quoting Vinod Koul (2019-09-05 21:56:59)
> Update the gcc qcs404 clock driver to use floor ops for sdcc clocks. As
> disuccsed in [1] it is good idea to use floor ops for sdcc clocks as we
> dont want the clock rates to do round up.
>
> [1]: https://lore.kernel.org/linux-arm-msm/20190830195142.103564-1-swboyd@chromium.org/
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-09 10:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 4:56 [PATCH] clk: qcom: gcc-qcs404: Use floor ops for sdcc clks Vinod Koul
2019-09-06 19:55 ` Bjorn Andersson
2019-09-06 20:38 ` Stephen Boyd
2019-09-07 7:48 ` Vinod Koul
2019-09-09 7:48 ` Taniya Das
2019-09-09 10:24 ` Stephen Boyd
2019-09-09 10:25 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).