From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07492C4CEC9 for ; Wed, 18 Sep 2019 06:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF67A21924 for ; Wed, 18 Sep 2019 06:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786855; bh=jNhbz67CJr/g2fdjXe+N+K8ckAY7k1eWl83twN0NrXA=; h=In-Reply-To:References:Cc:To:From:Subject:Date:List-ID:From; b=1Fl/U3inHCNDMhoafj+aXAX96AILqA1uhWWCuFnd3wurfHfcL1/OWl5GQXt5XoxzW H7LPOSutLZkKsQ34fXjCe2M1wGwEaMlINIfHt5pySRvcUq8G3eido+JzZkxF/2/h8D SjjZhRMMiNFINIE5HO8P9IDvE70r7VpXVZG4DHn0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728061AbfIRGHc (ORCPT ); Wed, 18 Sep 2019 02:07:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:34938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfIRGHb (ORCPT ); Wed, 18 Sep 2019 02:07:31 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A60220856; Wed, 18 Sep 2019 06:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786851; bh=jNhbz67CJr/g2fdjXe+N+K8ckAY7k1eWl83twN0NrXA=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=i2K8gJQM0HbM2ZNZSIwPgK+a8ru9cYl2eYOub+t5Aa/Mll4ya7fal7MFOxBo3K1dg pdLVcFKnMNOcHv4rPXBY4N8/rM/YuFsCVOZ0vr/m37Lcis9s47eUYJ2fcQdBGS0Hl5 qXtjMqa4X5+nBV7I8vdwJIESc5HPNhuRphWFOQIc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1568043491-20680-4-git-send-email-peng.fan@nxp.com> References: <1568043491-20680-1-git-send-email-peng.fan@nxp.com> <1568043491-20680-4-git-send-email-peng.fan@nxp.com> Cc: "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , Jacky Bai , Abel Vesa , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , Peng Fan To: "festevam@gmail.com" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Peng Fan From: Stephen Boyd Subject: Re: [PATCH V3 3/4] clk: imx: imx8mm: fix pll mux bit User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 23:07:30 -0700 Message-Id: <20190918060731.1A60220856@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Peng Fan (2019-09-08 20:39:44) > From: Peng Fan >=20 > pll BYPASS bit should be kept inside pll driver for glitchless freq > setting following spec. If exposing the bit, that means pll driver and > clk driver has two paths to touch this bit, which is wrong. >=20 > So use EXT_BYPASS bit here. >=20 > And drop uneeded set parent, because EXT_BYPASS default is 0. >=20 > Fixes: ba5625c3e272 ("clk: imx: Add clock driver support for imx8mm") > Suggested-by: Jacky Bai > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- Applied to clk-next