From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49CA8C4CEC4 for ; Wed, 18 Sep 2019 06:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1322E21906 for ; Wed, 18 Sep 2019 06:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786856; bh=Ts05YE0IjGolvN6Z7Hv/3J3qFt2qBGevkokf4x6n7e0=; h=In-Reply-To:References:Cc:To:From:Subject:Date:List-ID:From; b=iemHZlhBalIvuh9WcKUM60nt4OBHMcQy8XHLq6Ps9O+BAf5HM9aar5jnOzsesjzkF oaGcP2s9OovOyYxvujI9nBVZ3k7wx0nI1jP2CSsXGDrIpKEOz1CTojtrGXaKYlh3ZI 2hauGeGVlur7MGgFIs5RdONMYHo5/zDn9orWMdEc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726931AbfIRGHf (ORCPT ); Wed, 18 Sep 2019 02:07:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:35036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728056AbfIRGHf (ORCPT ); Wed, 18 Sep 2019 02:07:35 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B90EA20856; Wed, 18 Sep 2019 06:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568786854; bh=Ts05YE0IjGolvN6Z7Hv/3J3qFt2qBGevkokf4x6n7e0=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=VdmBBFmXgopq7WcGmLHBMOdq5W0g7H88njURoDcrLWaKfJehCItaEm+WjAX/cGPj0 aHSQG2CE+Csjnw3ZTuB0GlFyoXYDY42es+HDJhbIQ7LvhScgwRUvAMXNf/UCej6nTF ImrBB8oBgAcQcaYSzx7PFhDUTBYCi+PaevSVcNc8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1568043491-20680-5-git-send-email-peng.fan@nxp.com> References: <1568043491-20680-1-git-send-email-peng.fan@nxp.com> <1568043491-20680-5-git-send-email-peng.fan@nxp.com> Cc: "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , Jacky Bai , Abel Vesa , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez , Peng Fan To: "festevam@gmail.com" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Peng Fan From: Stephen Boyd Subject: Re: [PATCH V3 4/4] clk: imx: imx8mn: fix pll mux bit User-Agent: alot/0.8.1 Date: Tue, 17 Sep 2019 23:07:33 -0700 Message-Id: <20190918060734.B90EA20856@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Peng Fan (2019-09-08 20:39:50) > From: Peng Fan >=20 > pll BYPASS bit should be kept inside pll driver for glitchless freq > setting following spec. If exposing the bit, that means pll driver and > clk driver has two paths to touch this bit, which is wrong. >=20 > So use EXT_BYPASS bit here. >=20 > And drop uneeded set parent, because EXT_BYPASS default is 0. >=20 > Suggested-by: Jacky Bai > Reviewed-by: Leonard Crestez > Signed-off-by: Peng Fan > --- Applied to clk-next