From: Andrew Lunn <andrew@lunn.ch>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>, Tero Kristo <t-kristo@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] clk: let init callback return an error code
Date: Tue, 24 Sep 2019 18:19:39 +0200 [thread overview]
Message-ID: <20190924161939.GD28770@lunn.ch> (raw)
In-Reply-To: <20190924123954.31561-3-jbrunet@baylibre.com>
On Tue, Sep 24, 2019 at 02:39:53PM +0200, Jerome Brunet wrote:
> If the init callback is allowed to request resources, it needs a return
> value to report the outcome of such a request.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>
> Sorry about the spam.
> This patch change quite a few files so I have tried to Cc the
> relevant people. Stephen, You may notice that I have added a
> couple of the network people. You need an Ack from one of them
> since the Amlogic G12a mdio mux has a clock which uses the .init()
> callback
> static void __init of_ti_clockdomain_setup(struct device_node *node)
> diff --git a/drivers/net/phy/mdio-mux-meson-g12a.c b/drivers/net/phy/mdio-mux-meson-g12a.c
> index 7a9ad54582e1..bf86c9c7a288 100644
> --- a/drivers/net/phy/mdio-mux-meson-g12a.c
> +++ b/drivers/net/phy/mdio-mux-meson-g12a.c
> @@ -123,7 +123,7 @@ static int g12a_ephy_pll_is_enabled(struct clk_hw *hw)
> return (val & PLL_CTL0_LOCK_DIG) ? 1 : 0;
> }
>
> -static void g12a_ephy_pll_init(struct clk_hw *hw)
> +static int g12a_ephy_pll_init(struct clk_hw *hw)
> {
> struct g12a_ephy_pll *pll = g12a_ephy_pll_to_dev(hw);
>
> @@ -136,6 +136,8 @@ static void g12a_ephy_pll_init(struct clk_hw *hw)
> writel(0x20200000, pll->base + ETH_PLL_CTL5);
> writel(0x0000c002, pll->base + ETH_PLL_CTL6);
> writel(0x00000023, pll->base + ETH_PLL_CTL7);
> +
> + return 0;
> }
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
It should be safe to merge this via the clk tree. You would probably
know about an possible merge conflicts, since you wrote this driver!
Andrew
next prev parent reply other threads:[~2019-09-24 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 12:39 [PATCH 0/3] clk: let clock perform allocation in init Jerome Brunet
2019-09-24 12:39 ` [PATCH 1/3] clk: actually call the clock init before any other callback of the clock Jerome Brunet
2019-12-24 2:59 ` Stephen Boyd
2019-09-24 12:39 ` [PATCH 2/3] clk: let init callback return an error code Jerome Brunet
2019-09-24 13:38 ` Ankur Tyagi
2019-09-24 14:10 ` Jerome Brunet
2019-09-24 16:19 ` Andrew Lunn [this message]
2019-09-29 19:33 ` Heiko Stuebner
2019-09-24 12:39 ` [PATCH 3/3] clk: add terminate callback to clk_ops Jerome Brunet
2019-12-24 2:59 ` Stephen Boyd
2019-11-18 10:08 ` [PATCH 0/3] clk: let clock perform allocation in init Jerome Brunet
2019-11-29 15:36 ` Jerome Brunet
2019-12-03 9:05 ` Stephen Boyd
2019-12-16 9:17 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924161939.GD28770@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).