Linux-Clk Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] clk: at91: sam9x60: fix programmable clock
@ 2019-09-24 10:39 Eugen.Hristev
  2019-09-24 11:53 ` Nicolas.Ferre
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Eugen.Hristev @ 2019-09-24 10:39 UTC (permalink / raw)
  To: mturquette, sboyd, alexandre.belloni, linux-clk,
	linux-arm-kernel, linux-kernel
  Cc: Nicolas.Ferre, Eugen.Hristev

From: Eugen Hristev <eugen.hristev@microchip.com>

The prescaler mask for sam9x60 must be 0xff (8 bits).
Being set to 0, means that we cannot set any prescaler, thus the
programmable clocks do not work (except the case with prescaler 0)
Set the mask accordingly in layout struct.

Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
 drivers/clk/at91/sam9x60.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
index 9790ddf..86238d5 100644
--- a/drivers/clk/at91/sam9x60.c
+++ b/drivers/clk/at91/sam9x60.c
@@ -43,6 +43,7 @@ static const struct clk_pll_characteristics upll_characteristics = {
 };
 
 static const struct clk_programmable_layout sam9x60_programmable_layout = {
+	.pres_mask = 0xff,
 	.pres_shift = 8,
 	.css_mask = 0x1f,
 	.have_slck_mck = 0,
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: at91: sam9x60: fix programmable clock
  2019-09-24 10:39 [PATCH] clk: at91: sam9x60: fix programmable clock Eugen.Hristev
@ 2019-09-24 11:53 ` Nicolas.Ferre
  2019-09-24 12:00 ` Alexandre Belloni
  2019-10-03 20:59 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Nicolas.Ferre @ 2019-09-24 11:53 UTC (permalink / raw)
  To: Eugen.Hristev, mturquette, sboyd, alexandre.belloni, linux-clk,
	linux-arm-kernel, linux-kernel

On 24/09/2019 at 12:39, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> The prescaler mask for sam9x60 must be 0xff (8 bits).
> Being set to 0, means that we cannot set any prescaler, thus the
> programmable clocks do not work (except the case with prescaler 0)
> Set the mask accordingly in layout struct.
> 
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks Eugen. Best regards,
   Nicolas

> ---
>   drivers/clk/at91/sam9x60.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 9790ddf..86238d5 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -43,6 +43,7 @@ static const struct clk_pll_characteristics upll_characteristics = {
>   };
>   
>   static const struct clk_programmable_layout sam9x60_programmable_layout = {
> +	.pres_mask = 0xff,
>   	.pres_shift = 8,
>   	.css_mask = 0x1f,
>   	.have_slck_mck = 0,
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: at91: sam9x60: fix programmable clock
  2019-09-24 10:39 [PATCH] clk: at91: sam9x60: fix programmable clock Eugen.Hristev
  2019-09-24 11:53 ` Nicolas.Ferre
@ 2019-09-24 12:00 ` Alexandre Belloni
  2019-10-03 20:59 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2019-09-24 12:00 UTC (permalink / raw)
  To: Eugen.Hristev
  Cc: mturquette, sboyd, linux-clk, linux-arm-kernel, linux-kernel,
	Nicolas.Ferre

On 24/09/2019 10:39:09+0000, Eugen.Hristev@microchip.com wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> The prescaler mask for sam9x60 must be 0xff (8 bits).
> Being set to 0, means that we cannot set any prescaler, thus the
> programmable clocks do not work (except the case with prescaler 0)
> Set the mask accordingly in layout struct.
> 
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  drivers/clk/at91/sam9x60.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
> index 9790ddf..86238d5 100644
> --- a/drivers/clk/at91/sam9x60.c
> +++ b/drivers/clk/at91/sam9x60.c
> @@ -43,6 +43,7 @@ static const struct clk_pll_characteristics upll_characteristics = {
>  };
>  
>  static const struct clk_programmable_layout sam9x60_programmable_layout = {
> +	.pres_mask = 0xff,
>  	.pres_shift = 8,
>  	.css_mask = 0x1f,
>  	.have_slck_mck = 0,
> -- 
> 2.7.4
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: at91: sam9x60: fix programmable clock
  2019-09-24 10:39 [PATCH] clk: at91: sam9x60: fix programmable clock Eugen.Hristev
  2019-09-24 11:53 ` Nicolas.Ferre
  2019-09-24 12:00 ` Alexandre Belloni
@ 2019-10-03 20:59 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-10-03 20:59 UTC (permalink / raw)
  To: Eugen.Hristev, alexandre.belloni, linux-arm-kernel, linux-clk,
	linux-kernel, mturquette
  Cc: Nicolas.Ferre, Eugen.Hristev

Quoting Eugen.Hristev@microchip.com (2019-09-24 03:39:09)
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> The prescaler mask for sam9x60 must be 0xff (8 bits).
> Being set to 0, means that we cannot set any prescaler, thus the
> programmable clocks do not work (except the case with prescaler 0)
> Set the mask accordingly in layout struct.
> 
> Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver")
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---

Applied to clk-fixes


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 10:39 [PATCH] clk: at91: sam9x60: fix programmable clock Eugen.Hristev
2019-09-24 11:53 ` Nicolas.Ferre
2019-09-24 12:00 ` Alexandre Belloni
2019-10-03 20:59 ` Stephen Boyd

Linux-Clk Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-clk/0 linux-clk/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-clk linux-clk/ https://lore.kernel.org/linux-clk \
		linux-clk@vger.kernel.org linux-clk@archiver.kernel.org
	public-inbox-index linux-clk

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-clk


AGPL code for this site: git clone https://public-inbox.org/ public-inbox