From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF736C4360C for ; Thu, 10 Oct 2019 19:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F6BE214E0 for ; Thu, 10 Oct 2019 19:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570736891; bh=jXIkbRU0oflIoHOMtUU/jK4XJNqOCPlVs8pWEr3VRsI=; h=In-Reply-To:References:From:To:Cc:Subject:Date:List-ID:From; b=iqTCtUaoHd7n6KVoU1dwGAUPdE4P2Z+8hc4hoHPdARs79sfTwoV4bx8Vdg1YGVTTa yBUb9UoTzqCjXITbtJNGqxpChcQem6MhgEXfv/CRxEnZj0DygHmfZ2WYvq48LiUIss Y5HuLTfehHCHXp174sll7mzcdecB8sWLyl6vVtZ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbfJJTsL (ORCPT ); Thu, 10 Oct 2019 15:48:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:45818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfJJTsL (ORCPT ); Thu, 10 Oct 2019 15:48:11 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47D062067B; Thu, 10 Oct 2019 19:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570736890; bh=jXIkbRU0oflIoHOMtUU/jK4XJNqOCPlVs8pWEr3VRsI=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=vga664TttFPejM4kjwOinqCsK/1/++6qmPAcZZa1ChrrfmrHfr8ITRlubo4Y5hEnO XYpklj3YM84bgLoIjvDot7SY7qV1bqZruOmWsNIjlLOT4187ZAdTW3yVXirOZd8Pxc qsAySe5ju+EirakXvUXYBmQ8nUmX/CSTTywBuBlU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <155389876377.20095.15037552865160559827@swboyd.mtv.corp.google.com> <20191010041551.6D7E0208C3@mail.kernel.org> From: Stephen Boyd To: Manu Gautam , Marc Gonzalez , Michael Turquette Cc: Jeffrey Hugo , Bjorn Andersson , linux-clk , MSM , Evan Green , Douglas Anderson , Vinod Koul , Amit Nischal Subject: Re: [PATCH v1] clk: qcom: Skip halt checks on gcc_pcie_0_pipe_clk for 8998 User-Agent: alot/0.8.1 Date: Thu, 10 Oct 2019 12:48:09 -0700 Message-Id: <20191010194810.47D062067B@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Manu Gautam (2019-10-10 00:33:32) > Hi, >=20 > On 10/10/2019 9:45 AM, Stephen Boyd wrote: > > Quoting Manu Gautam (2019-10-09 01:31:09) > >> > [snip] > >> I have followed this up with QMP PHY hardware designers and they have > >> confirmed that QMP PHY must have pipe clock enabled at the beginning > >> of initialization sequence i.e. before bringing it out of reset and st= arting it. > > Awesome, thanks for following up. > > > >> Otherwise there is possibility of incorrect locking of pipe_interface/ > >> retime buffers in PHY. > >> Hence, for both USB and PCIe we have to continue to use HALT_SKIP flag. > > Does anything go wrong if we just leave these clks enabled forever out > > of boot? I'm inclined to rip the clks out and just slam the branch > > enable bit on all the time in gcc driver probe and return NULL to the > > callers of clk_get() for these clks. I don't see how this would be a > > problem because when the upstream phy is disabled this clk is disabled > > and so we aren't wasting power. It should also save us time and memory > > because now we don't have to call into the clk framework to turn it on > > and sequence that just right in the phy driver. >=20 > That might work, however on some platforms gcc_pipe_clk parent is changed= to > XO and back to phy_pipe_clk across low power mode. > It requires PHY driver to use clk_set_parent(). >=20 Hm ok. Where is the call to clk_set_parent()? I don't see this in the kernel. $ git grep clk_set_parent -- drivers/usb/phy drivers/phy | wc -l 0 What platforms do this? Are they upstream?