From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 227DEECE58E for ; Fri, 11 Oct 2019 15:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E57BB2245C for ; Fri, 11 Oct 2019 15:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570806230; bh=wmzKXszFXADx7E79A+Klk2pmPS9g69LOqyaLIPSL4Uo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jjsIImYBi4A7XyQnJ8XjICBoBeaUoi6+g5AuvZX+fVZ0rAO332InM6NoCtl0bTDub FnqM6cPEHtWrmRRPivyeHuV3dJYfXd1pgR4esjAgGfWcWQv+P7CYiP9lHV1IpIH/ig zdyqaPK/0JEituR+I76RmTQcia8ckXfNxS5pbRk8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727208AbfJKPDq (ORCPT ); Fri, 11 Oct 2019 11:03:46 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:44623 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726331AbfJKPDq (ORCPT ); Fri, 11 Oct 2019 11:03:46 -0400 Received: by mail-oi1-f194.google.com with SMTP id w6so8211697oie.11; Fri, 11 Oct 2019 08:03:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zf/wVL1pxkzfv+aCf542wtXl7xxXSJSAoS259hxFzdU=; b=ZT5G1Ep9m9sdmxD9aRrI7JBV+1iAH1nziaVnT5UuhjykMWAH0y43egukN3LdF+HdLF hgg9kq6479FfkTH2hVxTQ5TMvdgUw0FQ8SnAPr8n8E9GSe0x6dw8mqvoUqX0m4G91oGj 6aZ69DB5gBW9HrrQQujqCjFx//kQOgHlIcEjtf5mSm1xRGmUqn8PGr8qXqIpAxxQrHz5 2JdSSjr7vEuXJ84R8UtRSHmDkU9XvIG7G087MV+HPwzJcVy+YFZuD9B6t+lv0/EAeW/X 4MfZmXmLSLQwoteKTwnCZHibAkVIOqVxSnBoh0GHS1CnbYsAqW7gIaiiC4In1pImA+0y acwA== X-Gm-Message-State: APjAAAXU5Jerg4nkTnRn4lU7BKjsh5kzsq5okUOAKcLbtTQo+r5mPaoH Q0Wts09wFLHAdcackwUKxQ== X-Google-Smtp-Source: APXvYqyV76Nvy442IRIoZov+TB1OwfgmfaBvOSHiGvU7dcH19CN5WjOOfWxDjsuT1iB1kLR3NqyaCA== X-Received: by 2002:aca:5786:: with SMTP id l128mr12933151oib.34.1570806222672; Fri, 11 Oct 2019 08:03:42 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l47sm2791691ota.56.2019.10.11.08.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 08:03:39 -0700 (PDT) Date: Fri, 11 Oct 2019 10:03:39 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Sudeep Holla , Mark Rutland , Michael Turquette , Stephen Boyd , Kevin Hilman , "Rafael J. Wysocki" , Ulf Hansson , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema Message-ID: <20191011150339.GA16245@bogus> References: <20191002160632.11140-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002160632.11140-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, Oct 02, 2019 at 06:06:30PM +0200, Krzysztof Kozlowski wrote: > Convert Generic Power Domain bindings to DT schema format using > json-schema. The consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Select all nodes for consumers, > 2. Remove from consumers duplicated properties with dt-schema, > 3. Fix power domain pattern, > 4. Remove unneeded types. > --- > .../devicetree/bindings/arm/arm,scmi.txt | 2 +- > .../devicetree/bindings/arm/arm,scpi.txt | 2 +- > .../bindings/arm/freescale/fsl,scu.txt | 2 +- > .../bindings/clock/clk-exynos-audss.txt | 2 +- > .../bindings/clock/exynos5433-clock.txt | 4 +- > .../bindings/clock/renesas,cpg-mssr.txt | 2 +- > .../clock/renesas,r8a7778-cpg-clocks.txt | 2 +- > .../clock/renesas,r8a7779-cpg-clocks.txt | 2 +- > .../clock/renesas,rcar-gen2-cpg-clocks.txt | 2 +- > .../bindings/clock/renesas,rz-cpg-clocks.txt | 2 +- > .../bindings/clock/ti/davinci/psc.txt | 2 +- > .../bindings/display/etnaviv/etnaviv-drm.txt | 2 +- > .../devicetree/bindings/display/msm/dpu.txt | 2 +- > .../devicetree/bindings/display/msm/mdp5.txt | 2 +- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 2 +- > .../firmware/nvidia,tegra186-bpmp.txt | 2 +- > .../bindings/media/imx7-mipi-csi2.txt | 3 +- > .../bindings/media/mediatek-jpeg-decoder.txt | 3 +- > .../bindings/media/mediatek-mdp.txt | 3 +- > .../bindings/opp/qcom-nvmem-cpufreq.txt | 2 +- > .../devicetree/bindings/pci/pci-keystone.txt | 2 +- > .../bindings/phy/ti,phy-am654-serdes.txt | 2 +- > .../bindings/power/amlogic,meson-gx-pwrc.txt | 2 +- > .../devicetree/bindings/power/fsl,imx-gpc.txt | 2 +- > .../bindings/power/fsl,imx-gpcv2.txt | 2 +- > .../power/power-domain-consumers.yaml | 105 +++++++++ > .../bindings/power/power-domain.yaml | 134 ++++++++++++ > .../bindings/power/power_domain.txt | 205 ------------------ > .../devicetree/bindings/power/qcom,rpmpd.txt | 2 +- > .../bindings/power/renesas,rcar-sysc.txt | 2 +- > .../bindings/power/renesas,sysc-rmobile.txt | 2 +- > .../bindings/power/xlnx,zynqmp-genpd.txt | 2 +- > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 2 +- > .../bindings/soc/mediatek/scpsys.txt | 2 +- > .../bindings/soc/ti/sci-pm-domain.txt | 2 +- > .../bindings/usb/nvidia,tegra124-xusb.txt | 4 +- > MAINTAINERS | 2 +- > 37 files changed, 278 insertions(+), 241 deletions(-) > create mode 100644 Documentation/devicetree/bindings/power/power-domain-consumers.yaml > create mode 100644 Documentation/devicetree/bindings/power/power-domain.yaml > delete mode 100644 Documentation/devicetree/bindings/power/power_domain.txt > diff --git a/Documentation/devicetree/bindings/power/power-domain-consumers.yaml b/Documentation/devicetree/bindings/power/power-domain-consumers.yaml > new file mode 100644 > index 000000000000..f65078e1260e > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/power-domain-consumers.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/power-domain-consumers.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PM domain consumers > + > +maintainers: > + - Rafael J. Wysocki > + - Kevin Hilman > + - Ulf Hansson > + > +description: |+ > + See power-domain.yaml > + > +select: true > + > +allOf: > + - $ref: /schemas/power-domain/power-domain-consumer.yaml I don't like this split. We should move the contents of this file to the above file. I checked the authorship of the relevant lines and they are all except for a small number of lines from Linaro authors (Viresh and Ulf). I have permission from Linaro to dual license Linaro authored bindings, so it's not a problem to move this. I can do that and you can just drop this file. > + > +properties: > + required-opps: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + This contains phandle to an OPP node in another device's OPP table. > + It may contain an array of phandles, where each phandle points to an OPP > + of a different device. It should not contain multiple phandles to the OPP > + nodes in the same OPP table. This specifies the minimum required OPP > + of the device(s), whose OPP's phandle is present in this property, > + for the functioning of the current device at the current OPP (where this > + property is present). > + > +examples: > + - | > + leaky-device@12350000 { > + compatible = "foo,i-leak-current"; > + reg = <0x12350000 0x1000>; > + power-domains = <&power 0>; > + power-domain-names = "io"; > + }; > + > + leaky-device@12351000 { > + compatible = "foo,i-leak-current"; > + reg = <0x12351000 0x1000>; > + power-domains = <&power 0>, <&power 1> ; > + power-domain-names = "io", "clk"; > + }; > + > + // The first example above defines a typical PM domain consumer device, which is > + // located inside a PM domain with index 0 of a power controller represented by a > + // node with the label "power". > + // In the second example the consumer device are partitioned across two PM domains, > + // the first with index 0 and the second with index 1, of a power controller that > + // is represented by a node with the label "power". > + > + - | > + // Example with OPP table for domain provider that provides two domains: > + > + domain0_opp_table: opp-table0 { > + compatible = "operating-points-v2"; > + > + domain0_opp_0: opp-1000000000 { > + opp-hz = /bits/ 64 <1000000000>; > + opp-microvolt = <975000 970000 985000>; > + }; > + domain0_opp_1: opp-1100000000 { > + opp-hz = /bits/ 64 <1100000000>; > + opp-microvolt = <1000000 980000 1010000>; > + }; > + }; > + > + domain1_opp_table: opp-table1 { > + compatible = "operating-points-v2"; > + > + domain1_opp_0: opp-1200000000 { > + opp-hz = /bits/ 64 <1200000000>; > + opp-microvolt = <975000 970000 985000>; > + }; > + domain1_opp_1: opp-1300000000 { > + opp-hz = /bits/ 64 <1300000000>; > + opp-microvolt = <1000000 980000 1010000>; > + }; > + }; > + > + power: power-controller@12340000 { > + compatible = "foo,power-controller"; > + reg = <0x12340000 0x1000>; > + #power-domain-cells = <1>; > + operating-points-v2 = <&domain0_opp_table>, <&domain1_opp_table>; > + }; > + > + leaky-device0@12350000 { > + compatible = "foo,i-leak-current"; > + reg = <0x12350000 0x1000>; > + power-domains = <&power 0>; > + required-opps = <&domain0_opp_0>; > + }; > + > + leaky-device1@12350000 { > + compatible = "foo,i-leak-current"; > + reg = <0x12350000 0x1000>; > + power-domains = <&power 1>; > + required-opps = <&domain1_opp_1>; > + };