linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix typo in example
@ 2019-10-16 14:56 Geert Uytterhoeven
  2019-10-17  1:36 ` Yoshihiro Shimoda
  2019-10-29  1:27 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-10-16 14:56 UTC (permalink / raw)
  To: Yoshihiro Shimoda, Michael Turquette, Stephen Boyd, Rob Herring,
	Mark Rutland
  Cc: linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven

The documented compatible value for R-Car H3 is
"renesas,r8a7795-rcar-usb2-clock-sel", not
"renesas,r8a77950-rcar-usb2-clock-sel".

Fixes: 311accb64570db45 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This binding has no DTS users in upstream, nor in the BSP?
---
 .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
index e96e085271c134f4..83f6c6a7c41c76ca 100644
--- a/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
+++ b/Documentation/devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt
@@ -46,7 +46,7 @@ Required properties:
 Example (R-Car H3):
 
 	usb2_clksel: clock-controller@e6590630 {
-		compatible = "renesas,r8a77950-rcar-usb2-clock-sel",
+		compatible = "renesas,r8a7795-rcar-usb2-clock-sel",
 			     "renesas,rcar-gen3-usb2-clock-sel";
 		reg = <0 0xe6590630 0 0x02>;
 		clocks = <&cpg CPG_MOD 703>, <&usb_extal>, <&usb_xtal>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix typo in example
  2019-10-16 14:56 [PATCH] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix typo in example Geert Uytterhoeven
@ 2019-10-17  1:36 ` Yoshihiro Shimoda
  2019-10-29  1:27 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2019-10-17  1:36 UTC (permalink / raw)
  To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd, Rob Herring,
	Mark Rutland
  Cc: linux-clk, devicetree, linux-renesas-soc

Hi Geert-san,

> From: Of Geert Uytterhoeven, Sent: Wednesday, October 16, 2019 11:57 PM
> 
> The documented compatible value for R-Car H3 is
> "renesas,r8a7795-rcar-usb2-clock-sel", not
> "renesas,r8a77950-rcar-usb2-clock-sel".
> 
> Fixes: 311accb64570db45 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

> ---
> This binding has no DTS users in upstream, nor in the BSP?

That's correct for now.
So, I'll add this node into each .dtsi after I added the r8a77965 (also r8a77961?) compatible.
# I'll not enable the node though...

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix typo in example
  2019-10-16 14:56 [PATCH] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix typo in example Geert Uytterhoeven
  2019-10-17  1:36 ` Yoshihiro Shimoda
@ 2019-10-29  1:27 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-10-29  1:27 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Yoshihiro Shimoda, Michael Turquette, Stephen Boyd, Mark Rutland,
	linux-clk, devicetree, linux-renesas-soc, Geert Uytterhoeven

On Wed, 16 Oct 2019 16:56:50 +0200, Geert Uytterhoeven wrote:
> The documented compatible value for R-Car H3 is
> "renesas,r8a7795-rcar-usb2-clock-sel", not
> "renesas,r8a77950-rcar-usb2-clock-sel".
> 
> Fixes: 311accb64570db45 ("clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This binding has no DTS users in upstream, nor in the BSP?
> ---
>  .../devicetree/bindings/clock/renesas,rcar-usb2-clock-sel.txt   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-29  1:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 14:56 [PATCH] dt-bindings: clock: renesas: rcar-usb2-clock-sel: Fix typo in example Geert Uytterhoeven
2019-10-17  1:36 ` Yoshihiro Shimoda
2019-10-29  1:27 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).