From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4F7CA9EB5 for ; Mon, 4 Nov 2019 17:57:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8C26214D9 for ; Mon, 4 Nov 2019 17:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572890245; bh=x/tE30ugL9cXun8Vkc8mfGersrd/y4ViPXvLjtWqPIE=; h=In-Reply-To:References:Cc:From:Subject:To:Date:List-ID:From; b=Zku5pp1GZTIk2lYd3ct/+ujrVHBIK+N4tPsIeWezPrGctLYfuxIjiB36Kge7kf5po cow62xBT9VkArVS4yw0KKh5VD7ZImccSHg+CpRfUiy1IWntkvXykzdtaQ8Rgx7x1Z5 oe9Sxcw1twqmK7HWFeoShrWn6Gne/BgG/CRe1wNg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728876AbfKDR5Z (ORCPT ); Mon, 4 Nov 2019 12:57:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:36220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727469AbfKDR5Z (ORCPT ); Mon, 4 Nov 2019 12:57:25 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95B78214E0; Mon, 4 Nov 2019 17:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572890244; bh=x/tE30ugL9cXun8Vkc8mfGersrd/y4ViPXvLjtWqPIE=; h=In-Reply-To:References:Cc:From:Subject:To:Date:From; b=u9PaCoyMjipKxw2s8DiLg3QdCQySeWQ5NdUENpbKmMuaMn5aUVhne1wZu2hxOAXPh ImGhQM2qyDw6GnmCOwpqx4N97HP8dpHptCpeEaAwKeQJey7mg9Jeizqnyq7izlsvx3 r88ZU/g3fH/kqx7CtZe5o5jWnbe6B5rKzA9deWsk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190930154001.46581-1-tony@atomide.com> References: <20190930154001.46581-1-tony@atomide.com> Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, Keerthy From: Stephen Boyd Subject: Re: [PATCH] clk: ti: clkctrl: Fix failed to enable error with double udelay timeout To: Michael Turquette , Stephen Boyd , Tero Kristo , Tony Lindgren User-Agent: alot/0.8.1 Date: Mon, 04 Nov 2019 09:57:23 -0800 Message-Id: <20191104175724.95B78214E0@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Tony Lindgren (2019-09-30 08:40:01) > Commit 3d8598fb9c5a ("clk: ti: clkctrl: use fallback udelay approach if > timekeeping is suspended") added handling for cases when timekeeping is > suspended. But looks like we can still get occasional "failed to enable" > errors on the PM runtime resume path with udelay() returning faster than > expected. >=20 > With ti-sysc interconnect target module driver this leads into device > failure with PM runtime failing with "failed to enable" clkctrl error. >=20 > Let's fix the issue with a delay of two times the desired delay as in > often done for udelay() to account for the inaccuracy. >=20 > Fixes: 3d8598fb9c5a ("clk: ti: clkctrl: use fallback udelay approach if t= imekeeping is suspended") > Cc: Keerthy > Cc: Tero Kristo > Signed-off-by: Tony Lindgren > --- Applied to clk-fixes