From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163FEC43331 for ; Thu, 7 Nov 2019 21:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D48D72178F for ; Thu, 7 Nov 2019 21:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573163033; bh=JH9xA4nJOudRup6QA6tAKiiprVPdG/whs4CxVPLhFGw=; h=In-Reply-To:References:From:To:Cc:Subject:Date:List-ID:From; b=Aca2X79ctHTj6m5fBwuSjTQs3lybwOSxlOin9OomOEOSWviwubLUoCGM36RLcDzIn KNFD8HI9fWlXPBowhXyNU0Uv3941doPRUH3h9eOFxpoSIEpl5YEYbo4A8OmexWLMBr WAE8hlkocthS8enNgCHW1EVT6Ag0VLc7D3t7cXUM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbfKGVnx (ORCPT ); Thu, 7 Nov 2019 16:43:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:56272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbfKGVnx (ORCPT ); Thu, 7 Nov 2019 16:43:53 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A82E2166E; Thu, 7 Nov 2019 21:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573163032; bh=JH9xA4nJOudRup6QA6tAKiiprVPdG/whs4CxVPLhFGw=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=kBPm1x/Mce0IteeCTGnsUjx3gg/H6oFxeIOpmPkBuZQdkugIrTOClGkZWWvc6t8BW 7Mvu7ZQKVxDEUrGSXw6LP5GJvec1Z8Uivk5YEGmaRiMRVG1g98aXwSWHKicf2y1285 /lUpdhKMugQtareAO/aatqbAI1QcbwKMq71CZfeo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20191031185715.15504-1-jeffrey.l.hugo@gmail.com> References: <20191031185538.15402-1-jeffrey.l.hugo@gmail.com> <20191031185715.15504-1-jeffrey.l.hugo@gmail.com> From: Stephen Boyd To: Jeffrey Hugo , bjorn.andersson@linaro.org, mturquette@baylibre.com Cc: agross@kernel.org, marc.w.gonzalez@free.fr, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jeffrey Hugo Subject: Re: [PATCH v5 1/3] clk: qcom: Allow constant ratio freq tables for rcg User-Agent: alot/0.8.1 Date: Thu, 07 Nov 2019 13:43:51 -0800 Message-Id: <20191107214352.8A82E2166E@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Jeffrey Hugo (2019-10-31 11:57:15) > Some RCGs (the gfx_3d_src_clk in msm8998 for example) are basically just > some constant ratio from the input across the entire frequency range. It > would be great if we could specify the frequency table as a single entry > constant ratio instead of a long list, ie: >=20 > { .src =3D P_GPUPLL0_OUT_EVEN, .pre_div =3D 3 }, > { } >=20 > So, lets support that. >=20 > We need to fix a corner case in qcom_find_freq() where if the freq table > is non-null, but has no frequencies, we end up returning an "entry" before > the table array, which is bad. Then, we need ignore the freq from the > table, and instead base everything on the requested freq. >=20 > Suggested-by: Stephen Boyd > Signed-off-by: Jeffrey Hugo > --- Applied to clk-next and fixed the space thing. I guess ceil/floor rounding isn't a problem? =20