From: Stephen Boyd <sboyd@kernel.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
marc.w.gonzalez@free.fr, mturquette@baylibre.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH v6 3/6] clk: qcom: smd: Add XO clock for MSM8998
Date: Thu, 07 Nov 2019 13:50:15 -0800 [thread overview]
Message-ID: <20191107215016.A6CAD2084C@mail.kernel.org> (raw)
In-Reply-To: <1569959828-8357-1-git-send-email-jhugo@codeaurora.org>
Quoting Jeffrey Hugo (2019-10-01 12:57:08)
> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
> index 091acd59c1d6..1651a2f47ab8 100644
> --- a/drivers/clk/qcom/gcc-msm8998.c
> +++ b/drivers/clk/qcom/gcc-msm8998.c
> @@ -2971,14 +2957,23 @@ static const struct qcom_cc_desc gcc_msm8998_desc = {
> .num_resets = ARRAY_SIZE(gcc_msm8998_resets),
> .gdscs = gcc_msm8998_gdscs,
> .num_gdscs = ARRAY_SIZE(gcc_msm8998_gdscs),
> - .clk_hws = gcc_msm8998_hws,
> - .num_clk_hws = ARRAY_SIZE(gcc_msm8998_hws),
> };
>
> static int gcc_msm8998_probe(struct platform_device *pdev)
> {
> struct regmap *regmap;
> int ret;
> + struct clk *xo;
> +
> + /*
> + * We must have a valid XO to continue, otherwise having a missing
> + * parent on a system critical clock like the uart core clock can
> + * result in strange bugs. We know XO will be provided by rpmcc,
> + * but it might not be specified in DT like it should.
> + */
> + xo = __clk_lookup("xo");
I very much dislike __clk_lookup(). I think we can not have this patch?
> + if (!xo)
> + return -EPROBE_DEFER;
>
next prev parent reply other threads:[~2019-11-07 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 19:54 [PATCH v6 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-10-01 19:55 ` [PATCH v6 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-11-07 21:47 ` Stephen Boyd
2019-11-07 22:21 ` Jeffrey Hugo
2019-10-01 19:56 ` [PATCH v6 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-10-01 19:57 ` [PATCH v6 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-11-07 21:50 ` Stephen Boyd [this message]
2019-10-01 19:57 ` [PATCH v6 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-11-07 21:55 ` Stephen Boyd
2019-11-07 22:35 ` Jeffrey Hugo
2019-11-08 6:42 ` Stephen Boyd
2019-10-01 19:57 ` [PATCH v6 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-10-01 19:58 ` [PATCH v6 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107215016.A6CAD2084C@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).