linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Kitt <steve@sk2.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Paul Burton <paul.burton@mips.com>,
	Paul Cercueil <paul@crapouillou.net>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/clk: convert VL struct to struct_size
Date: Fri, 8 Nov 2019 13:34:14 +0100	[thread overview]
Message-ID: <20191108133414.72981353@heffalump.sk2.org> (raw)
In-Reply-To: <20191107225002.1520821D7F@mail.kernel.org>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Thu, 07 Nov 2019 14:50:01 -0800, Stephen Boyd <sboyd@kernel.org> wrote:
> Quoting Gustavo A. R. Silva (2019-10-02 12:20:28)
> > On 9/27/19 13:51, Stephen Kitt wrote:  
> > > There are a few manually-calculated variable-length struct allocations
> > > left, this converts them to use struct_size.
> > 
> > How did you find this?
> > 
> > Please, mention the tool you used to find this in the commit log. With
> > that you can add my
> > 
> > Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Any answer? I'm tempted to just apply the patch anyway.

Sorry, I hadn’t seen Gustavo’s email!

I didn’t use anything particularly fancy to find these, my history says

	git grep -A1 'kzalloc.*sizeof[^_].*+'

and manual review. I noticed that clk/ had a number of hits, but also commits
to switch to struct_size so I reckoned it was worth pursuing the exercise
there.

Is it worth adding that to the commit message?

Regards,

Stephen

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2019-11-08 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 18:51 [PATCH] drivers/clk: convert VL struct to struct_size Stephen Kitt
2019-10-02 19:20 ` Gustavo A. R. Silva
     [not found]   ` <20191107225002.1520821D7F@mail.kernel.org>
2019-11-08 12:34     ` Stephen Kitt [this message]
2019-11-08 16:37 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191108133414.72981353@heffalump.sk2.org \
    --to=steve@sk2.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=paul.burton@mips.com \
    --cc=paul@crapouillou.net \
    --cc=sboyd@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).