From: Tony Lindgren <tony@atomide.com>
To: Benoit Parrot <bparrot@ti.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2 3/5] ARM: dts: dra7: add vpe clkctrl node
Date: Fri, 8 Nov 2019 09:06:41 -0800 [thread overview]
Message-ID: <20191108170641.GI5610@atomide.com> (raw)
In-Reply-To: <20191108170231.ubwfu2nvcwjfabas@ti.com>
* Benoit Parrot <bparrot@ti.com> [191108 17:00]:
> Tony Lindgren <tony@atomide.com> wrote on Fri [2019-Nov-08 08:55:54 -0800]:
> > Hi,
> >
> > * Benoit Parrot <bparrot@ti.com> [191104 20:39]:
> > > Add clkctrl nodes for VPE module.
> >
> > Can you please add a comment describing that we currently need to
> > use custom node names here instead of the standard naming?
>
> Tony, what do you mean "custom node name" here?
> I followed the exact same syntax that was already there... confused..
Oh sorry for being unclear. Yeah so the conclusion of the discussion was
that we still need custom node names for now.
And for patch "[PATCH] clk: ti: add clkctrl data dra7 sgx" I added you to
Cc, and it has this in the patch description:
"Note that because of the current dts node name dependency for mapping to
clock domain, we must still use "gpu-clkctrl@" naming instead of generic
"clock@" naming for the node. And because of this, it's probably best to
apply the dts node addition together along with the other clock changes."
So can you please add something similar to your clock node patches too
to explain why we cannot use standard node names there?
Regards,
Tony
next prev parent reply other threads:[~2019-11-08 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 20:38 [Patch v2 0/5] ARM: dts: dra7: add vpe nodes Benoit Parrot
2019-11-04 20:38 ` [Patch v2 1/5] dt-bindings: media: ti-vpe: Document VPE driver Benoit Parrot
2019-11-05 23:05 ` Rob Herring
2019-11-04 20:38 ` [Patch v2 2/5] clk: ti: dra7: add vpe clkctrl data Benoit Parrot
2019-11-04 20:38 ` [Patch v2 3/5] ARM: dts: dra7: add vpe clkctrl node Benoit Parrot
2019-11-08 16:55 ` Tony Lindgren
2019-11-08 17:02 ` Benoit Parrot
2019-11-08 17:06 ` Tony Lindgren [this message]
2019-11-04 20:38 ` [Patch v2 4/5] ARM: dts: dra7: Add ti-sysc node for VPE Benoit Parrot
2019-11-04 20:38 ` [Patch v2 5/5] media: ti-vpe: vpe: fix compatible to match bindings Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108170641.GI5610@atomide.com \
--to=tony@atomide.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).