From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E83A3FC6195 for ; Fri, 8 Nov 2019 17:06:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFF4F218AE for ; Fri, 8 Nov 2019 17:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbfKHRGp (ORCPT ); Fri, 8 Nov 2019 12:06:45 -0500 Received: from muru.com ([72.249.23.125]:40934 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfKHRGp (ORCPT ); Fri, 8 Nov 2019 12:06:45 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BBC8480D4; Fri, 8 Nov 2019 17:07:20 +0000 (UTC) Date: Fri, 8 Nov 2019 09:06:41 -0800 From: Tony Lindgren To: Benoit Parrot Cc: Hans Verkuil , Tero Kristo , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2 3/5] ARM: dts: dra7: add vpe clkctrl node Message-ID: <20191108170641.GI5610@atomide.com> References: <20191104203841.3628-1-bparrot@ti.com> <20191104203841.3628-4-bparrot@ti.com> <20191108165554.GF5610@atomide.com> <20191108170231.ubwfu2nvcwjfabas@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108170231.ubwfu2nvcwjfabas@ti.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org * Benoit Parrot [191108 17:00]: > Tony Lindgren wrote on Fri [2019-Nov-08 08:55:54 -0800]: > > Hi, > > > > * Benoit Parrot [191104 20:39]: > > > Add clkctrl nodes for VPE module. > > > > Can you please add a comment describing that we currently need to > > use custom node names here instead of the standard naming? > > Tony, what do you mean "custom node name" here? > I followed the exact same syntax that was already there... confused.. Oh sorry for being unclear. Yeah so the conclusion of the discussion was that we still need custom node names for now. And for patch "[PATCH] clk: ti: add clkctrl data dra7 sgx" I added you to Cc, and it has this in the patch description: "Note that because of the current dts node name dependency for mapping to clock domain, we must still use "gpu-clkctrl@" naming instead of generic "clock@" naming for the node. And because of this, it's probably best to apply the dts node addition together along with the other clock changes." So can you please add something similar to your clock node patches too to explain why we cannot use standard node names there? Regards, Tony