From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF75C43331 for ; Tue, 12 Nov 2019 15:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A76BD21925 for ; Tue, 12 Nov 2019 15:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727166AbfKLPef (ORCPT ); Tue, 12 Nov 2019 10:34:35 -0500 Received: from muru.com ([72.249.23.125]:41840 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726376AbfKLPef (ORCPT ); Tue, 12 Nov 2019 10:34:35 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 056FD80F3; Tue, 12 Nov 2019 15:35:10 +0000 (UTC) Date: Tue, 12 Nov 2019 07:34:31 -0800 From: Tony Lindgren To: Benoit Parrot Cc: Tero Kristo , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 05/10] ARM: dts: DRA72: Add CAL dtsi node Message-ID: <20191112153431.GH5610@atomide.com> References: <20191112142753.22976-1-bparrot@ti.com> <20191112142753.22976-6-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112142753.22976-6-bparrot@ti.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org * Benoit Parrot [191112 14:25]: > This patch adds the required dtsi node to support the Camera > Adaptation Layer (CAL) for the DRA72 family of devices. > > Signed-off-by: Benoit Parrot > --- > arch/arm/boot/dts/dra72x.dtsi | 43 +++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm/boot/dts/dra72x.dtsi b/arch/arm/boot/dts/dra72x.dtsi > index f5762709c853..726e46ae887d 100644 > --- a/arch/arm/boot/dts/dra72x.dtsi > +++ b/arch/arm/boot/dts/dra72x.dtsi > @@ -17,6 +17,49 @@ > }; > }; > > +&l4_per2 { > + target-module@5b000 { /* 0x4845b000, ap 59 46.0 */ > + compatible = "ti,sysc-omap4", "ti,sysc"; > + reg = <0x5b000 0x4>, > + <0x5b010 0x4>; > + reg-names = "rev", "sysc"; > + ti,sysc-midle = , > + ; > + ti,sysc-sidle = , > + ; > + clocks = <&cam_clkctrl DRA7_CAM_VIP2_CLKCTRL 0>; > + clock-names = "fck"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x5b000 0x1000>; > + > + cal: cal@0 { > + compatible = "ti,dra72-cal"; > + reg = <0x0000 0x400>, > + <0x0800 0x40>, > + <0x0900 0x40>; > + reg-names = "cal_top", > + "cal_rx_core0", > + "cal_rx_core1"; > + interrupts = ; > + ti,camerrx-control = <&scm_conf 0xE94>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + csi2_0: port@0 { > + reg = <0>; > + }; > + csi2_1: port@1 { > + reg = <1>; > + }; > + }; > + }; > + }; > +}; Just leave out the status = "disabled" here for the SoC specific dtsi files. The SoC internal device is there for sure, even if not pinned out. And the dts default value is status = "okay". Regards, Tony