* [PATCH] clk: ti: dra7-atl: Remove pm_runtime_irq_safe()
@ 2019-11-14 10:17 Peter Ujfalusi
2019-11-14 16:50 ` Tony Lindgren
2020-01-06 3:04 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2019-11-14 10:17 UTC (permalink / raw)
To: t-kristo, mturquette; +Cc: sboyd, linux-omap, linux-clk, linux-kernel, tony
This is not needed for anything, and prevents proper PM transitions for
parent devices which is bad in case of ti-sysc; this effectively kills
PM completely. Thus, remove the flag.
Suggested-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/clk/ti/clk-dra7-atl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index f65e16c4f3c4..8d4c08b034bd 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -233,7 +233,6 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
cinfo->iobase = of_iomap(node, 0);
cinfo->dev = &pdev->dev;
pm_runtime_enable(cinfo->dev);
- pm_runtime_irq_safe(cinfo->dev);
pm_runtime_get_sync(cinfo->dev);
atl_write(cinfo, DRA7_ATL_PCLKMUX_REG(0), DRA7_ATL_PCLKMUX);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: ti: dra7-atl: Remove pm_runtime_irq_safe()
2019-11-14 10:17 [PATCH] clk: ti: dra7-atl: Remove pm_runtime_irq_safe() Peter Ujfalusi
@ 2019-11-14 16:50 ` Tony Lindgren
2020-01-06 3:04 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2019-11-14 16:50 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: t-kristo, mturquette, sboyd, linux-omap, linux-clk, linux-kernel
* Peter Ujfalusi <peter.ujfalusi@ti.com> [191114 10:16]:
> This is not needed for anything, and prevents proper PM transitions for
> parent devices which is bad in case of ti-sysc; this effectively kills
> PM completely. Thus, remove the flag.
Good to hear and thanks for clearing this one:
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: ti: dra7-atl: Remove pm_runtime_irq_safe()
2019-11-14 10:17 [PATCH] clk: ti: dra7-atl: Remove pm_runtime_irq_safe() Peter Ujfalusi
2019-11-14 16:50 ` Tony Lindgren
@ 2020-01-06 3:04 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-01-06 3:04 UTC (permalink / raw)
To: Peter Ujfalusi, mturquette, t-kristo
Cc: linux-omap, linux-clk, linux-kernel, tony
Quoting Peter Ujfalusi (2019-11-14 02:17:18)
> This is not needed for anything, and prevents proper PM transitions for
> parent devices which is bad in case of ti-sysc; this effectively kills
> PM completely. Thus, remove the flag.
>
> Suggested-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
Applied to clk-fixes. Seems important to not ruin the PM experience.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-06 3:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 10:17 [PATCH] clk: ti: dra7-atl: Remove pm_runtime_irq_safe() Peter Ujfalusi
2019-11-14 16:50 ` Tony Lindgren
2020-01-06 3:04 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).