From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1437C432C3 for ; Thu, 14 Nov 2019 11:51:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 696BD206EF for ; Thu, 14 Nov 2019 11:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jrotw+Kw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfKNLvb (ORCPT ); Thu, 14 Nov 2019 06:51:31 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35213 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfKNLva (ORCPT ); Thu, 14 Nov 2019 06:51:30 -0500 Received: by mail-wr1-f66.google.com with SMTP id s5so6138846wrw.2; Thu, 14 Nov 2019 03:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2uRyBq/ocSFf3yEX9ZPEWq5/e4PBmT6xt4ppTITbgvY=; b=jrotw+Kw4B7gcA79dHBNwTzSw4F7im8RoccdO+drSJsQj6RIfKL339zWAZiyuOXSyo g9f+g+O65NetN52hSqJrUPXHMzmKI0yREm6MeMkx+6cftOmgUcG9p/5xPgUsDmx+aUbm PtUlM6NPiu+6YeMT75pd85Be9Rp4lYH5LLxlExTixG+v90+5ZoLaleFFKI5VdaCBU96y ldhdP7bzxNqi3U/nyi4aH4QOvRLYe88uomg5B/nAO9+aHs27r2STK/f02FNI4gP1VWAJ m/AFRx8a1kvm4X+pT5T6NC3BlCfgs7bxCHMxBmou+lEf5ObysMPifz4l1Dgodt4ojTg4 POEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2uRyBq/ocSFf3yEX9ZPEWq5/e4PBmT6xt4ppTITbgvY=; b=jpR7HSaKukTkAnXK85iR86Dp1B1dXEu5nobun2oIEvd/tVz+sul9RmcE674fYIcGv5 nggL4YpUnlGSLoq+eEmslE49wxon/uTHcZefL/RRX4x+e7ZUguLFj4sLwDlC3VG/Rd9O n3OfCgy4LPMTvRr2o489qNTeQiGtyCIMHqyuN52BYKDsTDIjSMYygzU3USvazD1qEkTw HihmD9z/zDuh9/dM5iXYawH5ybQMobB1l96ebPtP3Zpwi+wiAGSlXfe13PXm7G6Io3OL T/i8MPBbO+xO+PF0nC1gIOZHtuptwEJP60KWeq0Zu0TRUTVrNawRaTcQ5UuY2ORgIWnE d9jg== X-Gm-Message-State: APjAAAV7ldkdT1io7MHSOVdtSGZgDrFhoHBvaGVJ5fS+cjBpfn6XMdRs 66jkoSFsFpV4ZipUdiZ/qwc= X-Google-Smtp-Source: APXvYqyM52eJG1tLEFUMT6JlPv10fJ8Tkf5Gjeitn9dG8M7NuyAYCziZ+Bc+aX6eq2ALYpcAuauC+g== X-Received: by 2002:a05:6000:10c5:: with SMTP id b5mr8275694wrx.121.1573732287121; Thu, 14 Nov 2019 03:51:27 -0800 (PST) Received: from localhost (p2E5BE2CE.dip0.t-ipconnect.de. [46.91.226.206]) by smtp.gmail.com with ESMTPSA id p4sm7097821wrx.71.2019.11.14.03.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 03:51:25 -0800 (PST) Date: Thu, 14 Nov 2019 12:51:24 +0100 From: Thierry Reding To: "kernelci.org bot" Cc: tomeu.vizoso@collabora.com, Stephen Boyd , guillaume.tucker@collabora.com, mgalka@collabora.com, Thierry Reding , broonie@kernel.org, matthew.hart@linaro.org, khilman@baylibre.com, enric.balletbo@collabora.com, Jonathan Hunter , linux-kernel@vger.kernel.org, Prashant Gaikwad , Peter De Schrijver , linux-tegra@vger.kernel.org, Michael Turquette , linux-clk@vger.kernel.org Subject: Re: clk/clk-next boot bisection: v5.4-rc1-201-ga228ae437aa5 on tegra124-nyan-big Message-ID: <20191114115124.GA5690@aiwendil> References: <5dccdf20.1c69fb81.418aa.a71c@mx.google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8t9RHnE3ZwKMSgU+" Content-Disposition: inline In-Reply-To: <5dccdf20.1c69fb81.418aa.a71c@mx.google.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --8t9RHnE3ZwKMSgU+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 13, 2019 at 08:59:12PM -0800, kernelci.org bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: "kernelci.org bot" * > * * > * Hope this helps! * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * >=20 > clk/clk-next boot bisection: v5.4-rc1-201-ga228ae437aa5 on tegra124-nyan-= big >=20 > Summary: > Start: a228ae437aa5 Merge branch 'clk-unused' into clk-next > Details: https://kernelci.org/boot/id/5dcc99e959b514100f138e14 > Plain log: https://storage.kernelci.org//clk/clk-next/v5.4-rc1-201-ga2= 28ae437aa5/arm/tegra_defconfig/gcc-8/lab-collabora/boot-tegra124-nyan-big.t= xt > HTML log: https://storage.kernelci.org//clk/clk-next/v5.4-rc1-201-ga2= 28ae437aa5/arm/tegra_defconfig/gcc-8/lab-collabora/boot-tegra124-nyan-big.h= tml > Result: 25175c806a68 clk: tegra: Reimplement SOR clock on Tegra124 >=20 > Checks: > revert: PASS > verify: PASS >=20 > Parameters: > Tree: clk > URL: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.g= it > Branch: clk-next > Target: tegra124-nyan-big > CPU arch: arm > Lab: lab-collabora > Compiler: gcc-8 > Config: tegra_defconfig > Test suite: boot >=20 > Breaking commit found: >=20 > -------------------------------------------------------------------------= ------ > commit 25175c806a6841149abe46168e0af12593141612 > Author: Thierry Reding > Date: Thu Jul 25 18:19:00 2019 +0200 >=20 > clk: tegra: Reimplement SOR clock on Tegra124 > =20 > In order to allow the display driver to deal uniformly with all SOR > generations, implement the SOR clocks in a way that is compatible with > Tegra186 and later. > =20 > Acked-by: Stephen Boyd > Signed-off-by: Thierry Reding This is expected. There are additional patches required to the Tegra DRM driver and device tree files to restore this. All of those patches are in linux-next, where Nyan is again functional. The breakage here is really unfortunate, but ultimately this boils down to the fact that this clock was wrongly implemented and things only work by accident currently. Thierry > diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-teg= ra124.c > index 7d231529c3a5..b3110d5b5a6c 100644 > --- a/drivers/clk/tegra/clk-tegra124.c > +++ b/drivers/clk/tegra/clk-tegra124.c > @@ -1005,20 +1005,24 @@ static struct tegra_devclk devclks[] __initdata = =3D { > { .con_id =3D "hda2hdmi", .dt_id =3D TEGRA124_CLK_HDA2HDMI }, > }; > =20 > -static const char *mux_pllp_pllm_plld_plla_pllc_plld2_clkm[] =3D { > - "pll_p", "pll_m", "pll_d_out0", "pll_a_out0", "pll_c", > - "pll_d2_out0", "clk_m" > +static const char * const sor0_parents[] =3D { > + "pll_p_out0", "pll_m_out0", "pll_d_out0", "pll_a_out0", "pll_c_out0", > + "pll_d2_out0", "clk_m", > }; > -#define mux_pllp_pllm_plld_plla_pllc_plld2_clkm_idx NULL > =20 > -static const char *mux_clkm_plldp_sor0out[] =3D { > - "clk_m", "pll_dp", "sor0_out", > +static const char * const sor0_out_parents[] =3D { > + "clk_m", "sor0_pad_clkout", > }; > -#define mux_clkm_plldp_sor0out_idx NULL > =20 > static struct tegra_periph_init_data tegra124_periph[] =3D { > - MUX8_NOGATE_LOCK("sor0_out", mux_pllp_pllm_plld_plla_pllc_plld2_clkm, C= LK_SOURCE_SOR0, tegra_clk_sor0_out, &sor0_lock), > - NODIV("sor0", mux_clkm_plldp_sor0out, CLK_SOURCE_SOR0, 14, 3, 182, 0, t= egra_clk_sor0, &sor0_lock), > + TEGRA_INIT_DATA_TABLE("sor0", NULL, NULL, sor0_parents, > + CLK_SOURCE_SOR0, 29, 0x7, 0, 0, 0, 0, > + 0, 182, 0, tegra_clk_sor0, NULL, 0, > + &sor0_lock), > + TEGRA_INIT_DATA_TABLE("sor0_out", NULL, NULL, sor0_out_parents, > + CLK_SOURCE_SOR0, 14, 0x1, 0, 0, 0, 0, > + 0, 0, TEGRA_PERIPH_NO_GATE, tegra_clk_sor0_out, > + NULL, 0, &sor0_lock), > }; > =20 > static struct clk **clks; > -------------------------------------------------------------------------= ------ >=20 >=20 > Git bisection log: >=20 > -------------------------------------------------------------------------= ------ > git bisect start > # good: [dafbb1e6473788cb3068eaeddc58f9d88e9c7a62] Merge branch 'clk-ti' = into clk-next > git bisect good dafbb1e6473788cb3068eaeddc58f9d88e9c7a62 > # bad: [a228ae437aa553736058cbbd58d2d0e191635cdc] Merge branch 'clk-unuse= d' into clk-next > git bisect bad a228ae437aa553736058cbbd58d2d0e191635cdc > # bad: [3214be6cb1e487b0f8c3bb2eac9b06df07a07e06] clk: tegra: Share clk a= nd rst register defines with Tegra clock driver > git bisect bad 3214be6cb1e487b0f8c3bb2eac9b06df07a07e06 > # bad: [05308d7e7bbc932025f1dafc401c73ce83c6f414] clk: tegra: Reimplement= SOR clocks on Tegra210 > git bisect bad 05308d7e7bbc932025f1dafc401c73ce83c6f414 > # good: [d1ee3173a139ed2eb8d87e06216f0426b16084d8] Merge branch 'for-5.5/= dt-bindings' into for-5.5/clk > git bisect good d1ee3173a139ed2eb8d87e06216f0426b16084d8 > # good: [e5f8a107d92db30a7ad7d8d95aee59f5ad76206a] clk: tegra: Move SOR0 = implementation to Tegra124 > git bisect good e5f8a107d92db30a7ad7d8d95aee59f5ad76206a > # bad: [25175c806a6841149abe46168e0af12593141612] clk: tegra: Reimplement= SOR clock on Tegra124 > git bisect bad 25175c806a6841149abe46168e0af12593141612 > # good: [da8d1a3555406275650b366460c6235f1696bf8b] clk: tegra: Rename sor= 0_lvds to sor0_out > git bisect good da8d1a3555406275650b366460c6235f1696bf8b > # first bad commit: [25175c806a6841149abe46168e0af12593141612] clk: tegra= : Reimplement SOR clock on Tegra124 > -------------------------------------------------------------------------= ------ --8t9RHnE3ZwKMSgU+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl3NP7gACgkQ3SOs138+ s6EMSw//bsAl2YetGdvn4aBmyU2U1dgVrOWQUJwS605tMb7WABoHhSQNXXBTqx7y 8XutLbixwOQ58hNSLt00hDKrea8WrG2HLyF+hmrf/15WVAORDcp6rUC+nZSYuFqo BXwXDdQ3WEFH2k0xuPsjoPk9fEtYMl85oyuwLbBX34RJVomFOMlrWWtR8R2lm/Q5 6Dfpyn71G/IhNNw4Pb1orMZZiGxv20SCezAp1is++mm8Svoiq7r8QbdkiSw/RZJ4 hwW1UiHkww2QALVjM4WL5Jjcv2LUA9Vw4Hey2v5tgaV0dgJLe8ZvMur1cTvoX3QD RJ0nnQUvEFbAvx+fmSLrNi9Vit/NfUwT/pam95LYKr+eLdXDeincidChOaHAQ9IN z/eTKoNDvaptwpIXY77LTDQtUsHRfxvGuQgafnoPzYpQvp1PntXLQN4CGzGtBzfE AGpp30sHEb5mYVqechr+ylKt4WzcHUY/D5oo5YCf8QpROHBI/R2W8Jr/6gUwr7JO V4WiD7++/dMOk/m10klGquOlWEQBVtwDTtnJWr+kVGtcD5Vw/UPsyBQYOlARObRc H3bI2CGIop7KfrC4F8jLpo8dPOZ3MQeQXOQQJI89uVVoDTpBYg+cN24frpvrnCo2 Ieqdx0FZO8tvb2ivWz0Bcadh2p/z8wzhzHNZS1Iu5RALGeEDxTw= =5XoD -----END PGP SIGNATURE----- --8t9RHnE3ZwKMSgU+--