From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B5AC432C0 for ; Mon, 18 Nov 2019 16:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9D5D218AE for ; Mon, 18 Nov 2019 16:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574094306; bh=oMYkZuMf6WhUQSXdhLctDMiyyOcrJ2SLjyrX8pyDpF8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2FbpUxnVajLeotesK6h6NtgjBrocB7vWisrE1potihiUvWoTHMrnSC0Ruu51IjaeC IHNm8HMd+zzuzJimuaVJzBmSGVDAhm829vUcdellePU7aJkXkw9Z3U3ebqdJ0AvATU A/3Mw1CMmhjvd+OjjZPWivB/j9kWRohrQ1t5nYhs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726322AbfKRQZG (ORCPT ); Mon, 18 Nov 2019 11:25:06 -0500 Received: from foss.arm.com ([217.140.110.172]:36762 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbfKRQZG (ORCPT ); Mon, 18 Nov 2019 11:25:06 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D16DEDA7; Mon, 18 Nov 2019 08:25:04 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12FD93F703; Mon, 18 Nov 2019 08:25:04 -0800 (PST) Date: Mon, 18 Nov 2019 16:25:02 +0000 From: Mark Brown To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Lee Jones , Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Mark Rutland , Liam Girdwood , Jonathan Corbet , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , Mauro Carvalho Chehab , Jeff Kirsher , Wolfram Sang , Marek Szyprowski , Heiner Kallweit , Nicholas Mc Guire , Phil Edworthy , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v5 01/16] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Message-ID: <20191118162502.GJ9761@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8tZVdKiiYitVG083" Content-Disposition: inline In-Reply-To: X-Cookie: no maintenance: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --8tZVdKiiYitVG083 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 18, 2019 at 08:53:57AM +0200, Matti Vaittinen wrote: > +#Supported default DVS states: > +#buck | run | idle | suspend | lpsr > +#-----------------------------------------------------------------------= ----- > +#1, 2, 6, and 7 | supported | supported | supported (*) > +#-----------------------------------------------------------------------= ----- > +#3, 4, and 5 | supported (**) > +#-----------------------------------------------------------------------= ----- > +#(*) LPSR and SUSPEND states use same voltage but both states have own = enable / > +# disable settings. Voltage 0 can be specified for a state to make r= egulator > +# disabled on that state. > +#(**) All states use same voltage but have own enable / disable settings. > +# Voltage 0 can be specified for a state to make regulator disabled = on that > +# state. > + > + rohm,dvs-runlvl-ctrl: > + description: | > + buck control is done based on run-level. Regulator is not > + individually controllable. See ../mfd/rohm,bd71828-pmic.yaml f= or > + how to specify run-level control mechanism. Only bucks 1, 2, 6 > + and 7 support this. > + type: boolean I don't think I saw this having the effect on set_voltage() that I'd have expected in the driver? =20 > + rohm,dvs-runlevel-microvolts: > + minimum: 0 > + maximum: 2000000 > + maxItems: 4 > + description: > + Array of voltages for run-levels. First value is for run-level= 0, > + second for run-level 1 etc. Microvolts. What's the mapping from array indexes to the names used elsewhere to support runlevels? --8tZVdKiiYitVG083 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3Sxd0ACgkQJNaLcl1U h9CCTwf/XyyhpE5QABB0yoyT4n2JEfyYggDTfnGhWaILUDJBNnJ7inK77EpoLaGL ybxABHwiIONAnVzWxn+N2THjqO+fbukf7LO6DvYe8FCfoaIz8A6qgGm+P9IC1CWw xeWdZwGwWh63iRZ+fR422SlmmNtykgb4QHUdvwEZ9fqMhqPgRGP6YWl5RSuCnC8R oE9SPG2GlA/I4kadkV6O503q496yvB6hLiOgXWZ3yWJY2uYNYJvn0sNpd+k0iZK4 H4iyzLTOIUiD3RpLgNTPrmYXn1D/wClO+l2FqRjpzgq7tDO4xVyEOY8bTH9MrFoD 36C7jhTJbW2tecxGFK5eemuG+i4Vxg== =mxuN -----END PGP SIGNATURE----- --8tZVdKiiYitVG083--